From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: msm8996-pcie-phy: Add support to msm8996 pcie phy
Date: Fri, 16 Sep 2016 17:49:18 +0100 [thread overview]
Message-ID: <e43b7441-6183-e15c-c944-620d3f376320@linaro.org> (raw)
In-Reply-To: <2afe8523-925f-b538-f217-23ea7a267e11@linaro.org>
On 16/09/16 15:14, Stanimir Varbanov wrote:
>> > + writel_relaxed(0x0f, base + QSERDES_COM_BG_TRIM);
>> > + writel_relaxed(0x0f, base + QSERDES_COM_PLL_IVCO);
>> > + writel_relaxed(0x19, base + QSERDES_COM_CLK_EP_DIV);
>> > + writel_relaxed(0x10, base + QSERDES_COM_CLK_ENABLE1);
>> > + writel_relaxed(0x00, base + QSERDES_COM_HSCLK_SEL);
>> > + writel_relaxed(0x40, base + QSERDES_COM_RESCODE_DIV_NUM);
>> > + writel_relaxed(0x00, base + PCIE_COM_SW_RESET);
>> > + writel_relaxed(0x03, base + PCIE_COM_START_CONTROL);
> I'd make an array with register/value pair and write the registers with
> a for () loop. IMO it will be more readable.
>
> Probably 3 arrays - power_on, power_on_common and power_off.
Thats good idea, I will keep that in mind before sending next version
with common phy driver for USB/PCIE/UFS.
thanks
srini
prev parent reply other threads:[~2016-09-16 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 10:55 [PATCH 0/2] phy: Add support msm8996/apq8096 pcie phy Srinivas Kandagatla
2016-09-07 10:55 ` [PATCH 1/2] dt-bindings: msm8996-pcie-phy: add support for msm8996 " Srinivas Kandagatla
2016-09-12 22:51 ` Stephen Boyd
2016-09-16 16:51 ` Srinivas Kandagatla
2016-09-16 13:52 ` Rob Herring
2016-09-16 16:45 ` Srinivas Kandagatla
2016-09-07 10:55 ` [PATCH 2/2] phy: msm8996-pcie-phy: Add support to " Srinivas Kandagatla
2016-09-13 16:06 ` Archit Taneja
2016-09-16 16:48 ` Srinivas Kandagatla
2016-09-16 14:14 ` Stanimir Varbanov
2016-09-16 16:49 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43b7441-6183-e15c-c944-620d3f376320@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).