From: Andrew Lunn <andrew@lunn.ch>
To: Guo Samin <samin.guo@starfivetech.com>
Cc: Conor Dooley <conor@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, Peter Geis <pgwipeout@gmail.com>,
Frank <Frank.Sae@motor-comm.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Yanhong Wang <yanhong.wang@starfivetech.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg
Date: Wed, 21 Jun 2023 16:13:07 +0200 [thread overview]
Message-ID: <e43d9cf4-8e44-4918-a181-2a3daa9c9b3c@lunn.ch> (raw)
In-Reply-To: <8e2a50b2-a9ab-e164-a3c2-b7bc11ccdb53@starfivetech.com>
> When we need to deal with current values at different voltages,
> using register values in drives may be simpler, comparing the
> current value.
Register values in DT are only allowed in the worst case if its all
undocumented vendor magic. You have the needed documentation, and its
easy code to write, lookup a value in a table.
Andrew
next prev parent reply other threads:[~2023-06-21 14:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 9:05 [PATCH v3 0/2] Add motorcomm phy pad-driver-strength-cfg support Samin Guo
2023-05-26 9:05 ` [PATCH v3 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg Samin Guo
2023-05-26 19:41 ` Conor Dooley
2023-05-29 3:46 ` Guo Samin
2023-06-20 3:09 ` Guo Samin
2023-06-20 8:26 ` Conor Dooley
2023-06-20 8:55 ` Krzysztof Kozlowski
2023-06-21 3:03 ` Guo Samin
2023-06-20 13:29 ` Andrew Lunn
2023-06-21 3:28 ` Guo Samin
2023-06-21 14:13 ` Andrew Lunn [this message]
2023-05-26 9:05 ` [PATCH v3 2/2] net: phy: motorcomm: Add pad drive strength cfg support Samin Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43d9cf4-8e44-4918-a181-2a3daa9c9b3c@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).