From: "shenyang (M)" <shenyang39@huawei.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Sihang Chen <chensihang1@hisilicon.com>,
<linux-crypto@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Zaibo Xu <xuzaibo@huawei.com>,
Zhou Wang <wangzhou1@hisilicon.com>
Subject: Re: [v4 01/10] crypto: hisilicon/qm - fix wrong release after using strsep
Date: Thu, 6 Aug 2020 09:33:51 +0800 [thread overview]
Message-ID: <e470a745-c59e-2baa-426d-816ae64d052f@huawei.com> (raw)
In-Reply-To: <5554863d-f0d7-a396-7d13-e187fa9ca6bf@web.de>
On 2020/8/5 14:04, Markus Elfring wrote:
>> Thanks for your review. There is only one error branch need to do
>> something uninit. So I think the jump is not necessary and will
>> affect code reading.:)
>
> How does this concern fit to the Linux coding style?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=4da9f3302615f4191814f826054846bf843e24fa#n481
>
> Regards,
> Markus
>
> .
>
Got it, I'll fix this.
Thanks,
Yang
next prev parent reply other threads:[~2020-08-06 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <96ffa633-dda1-7ad1-72da-5563906c1561@web.de>
2020-08-05 1:58 ` [PATCH v4 01/10] crypto: hisilicon/qm - fix wrong release after using strsep shenyang (M)
[not found] ` <5554863d-f0d7-a396-7d13-e187fa9ca6bf@web.de>
2020-08-06 1:33 ` shenyang (M) [this message]
[not found] ` <c28f472c-4d7b-0afd-5ad7-3cc322aad404@web.de>
2020-08-07 8:06 ` [v4 " shenyang (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e470a745-c59e-2baa-426d-816ae64d052f@huawei.com \
--to=shenyang39@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=chensihang1@hisilicon.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).