platform/x86/pcengines-apuv2: Missing apu4

platform/x86/pcengines-apuv2: Missing apu4

[Gerhard Wiesinger]

Hello,

I saw that the apu4 board is completly missing (also on 5.3rc1). Can you 
please add it. Should be very easy, see below.

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/platform/x86/pcengines-apuv2.c?h=v5.1.20

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/pcengines-apuv2.c?h=v5.3-rc1


For further rference:

https://www.pcengines.ch/apu2.htm

https://www.pcengines.ch/apu4c2.htm

https://www.pcengines.ch/apu4c4.htm

Please backport it also to 5.1.x and 5.2.x.


Thnx.

Ciao,

Gerhard


     /* APU4 w/ legacy bios < 4.0.8 */
     {
         .ident        = "apu4",
         .matches    = {
             DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
             DMI_MATCH(DMI_BOARD_NAME, "APU4")
         },
         .driver_data = (void *)&board_apu2,
     },
     /* APU4 w/ legacy bios >= 4.0.8 */
     {
         .ident       = "apu4",
         .matches     = {
             DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
             DMI_MATCH(DMI_BOARD_NAME, "apu4)
         },
         .driver_data = (void *)&board_apu2,
     },
     /* APU4 w/ mainline bios */
     {
         .ident       = "apu4",
         .matches     = {
             DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
             DMI_MATCH(DMI_BOARD_NAME, "PC Engines apu4")
         },
         .driver_data = (void *)&board_apu2,
     },


|

MODULE_DESCRIPTION("PC Engines APUv2/APUv3/APUv4 board GPIO/LED/keys 
driver"); |

Re: platform/x86/pcengines-apuv2: Missing apu4

[Enrico Weigelt, metux IT consult]

On 26.07.19 16:56, Gerhard Wiesinger wrote:
> Hello,
> 
> I saw that the apu4 board is completly missing (also on 5.3rc1). Can you 
> please add it. Should be very easy, see below.

Still in the pipeline - don't have an apu4 board for testing yet.


--mtx

-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287

Re: platform/x86/pcengines-apuv2: Missing apu4

[Gerhard Wiesinger]

On 29.07.2019 10:35, Enrico Weigelt, metux IT consult wrote:
> On 26.07.19 16:56, Gerhard Wiesinger wrote:
>> Hello,
>>
>> I saw that the apu4 board is completly missing (also on 5.3rc1). Can 
>> you please add it. Should be very easy, see below.
>
> Still in the pipeline - don't have an apu4 board for testing yet.
>
>
Delta to e.g. apu3 can be found in the repo, see below 
(https://github.com/pcengines/coreboot)


dmidecode|grep -iE 'engines|apu'
         Manufacturer: PC Engines
         Product Name: apu4
         Manufacturer: PC Engines
         Product Name: apu4
         Manufacturer: PC Engines

So risk of the patch is minimal.


I can test it if patch is integrated.

Ciao,

Gerhard

--- pcengines_apu3.config    Fri Jul 26 11:33:41 2019
+++ pcengines_apu4.config    Fri Jul 26 11:33:41 2019
@@ -30,14 +30,14 @@
  #
  CONFIG_VENDOR_PCENGINES=y
  # CONFIG_BOARD_PCENGINES_APU2 is not set
-CONFIG_BOARD_PCENGINES_APU3=y
-# CONFIG_BOARD_PCENGINES_APU4 is not set
+# CONFIG_BOARD_PCENGINES_APU3 is not set
+CONFIG_BOARD_PCENGINES_APU4=y
  # CONFIG_BOARD_PCENGINES_APU5 is not set
  CONFIG_BOARD_SPECIFIC_OPTIONS=y
-CONFIG_VARIANT_DIR="apu3"
+CONFIG_VARIANT_DIR="apu4"
  CONFIG_DEVICETREE="variants/$(CONFIG_VARIANT_DIR)/devicetree.cb"
  CONFIG_MAINBOARD_DIR="pcengines/apu2"
-CONFIG_MAINBOARD_PART_NUMBER="apu3"
+CONFIG_MAINBOARD_PART_NUMBER="apu4"
  # CONFIG_SVI2_SLOW_SPEED is not set
  CONFIG_SVI_WAIT_COMP_DIS=y
  CONFIG_HW_MEM_HOLE_SIZEK=0x200000
@@ -397,7 +397,7 @@
  CONFIG_MAINBOARD_SERIAL_NUMBER="123456789"
  CONFIG_MAINBOARD_VERSION="1.0"
  CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="PC Engines"
-CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="apu3"
+CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="apu4"

  #
  # Payload