* [Proposal] DRM: AMD: Convert logging to drm_* functions.
@ 2020-07-08 16:11 Suraj Upadhyay
2020-07-09 7:14 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Suraj Upadhyay @ 2020-07-08 16:11 UTC (permalink / raw)
To: alexander.deucher, christian.koenig; +Cc: amd-gfx, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Hii AMD Maintainers,
I plan to convert logging of information, error and warnings
inside the AMD driver(s) to drm_* functions and macros for loggin,
as described by the TODO list in the DRM documentation[1].
I need your approval for the change before sending any patches, to make
sure that this is a good idea and that the patches will be merged.
The patches will essentially convert all the dev_info(), dev_warn(),
dev_err() and dev_err_once() to drm_info(), drm_warn(), drm_err() and
drm_err_once() respectively.
Thank You,
Suraj Upadhyay.
[1] https://dri.freedesktop.org/docs/drm/gpu/todo.html#convert-logging-to-drm-functions-with-drm-device-paramater
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Proposal] DRM: AMD: Convert logging to drm_* functions.
2020-07-08 16:11 [Proposal] DRM: AMD: Convert logging to drm_* functions Suraj Upadhyay
@ 2020-07-09 7:14 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2020-07-09 7:14 UTC (permalink / raw)
To: Suraj Upadhyay, alexander.deucher; +Cc: amd-gfx, linux-kernel
Am 08.07.20 um 18:11 schrieb Suraj Upadhyay:
> Hii AMD Maintainers,
> I plan to convert logging of information, error and warnings
> inside the AMD driver(s) to drm_* functions and macros for loggin,
> as described by the TODO list in the DRM documentation[1].
>
> I need your approval for the change before sending any patches, to make
> sure that this is a good idea and that the patches will be merged.
>
> The patches will essentially convert all the dev_info(), dev_warn(),
> dev_err() and dev_err_once() to drm_info(), drm_warn(), drm_err() and
> drm_err_once() respectively.
Well to be honest I would rather like see the conversion done in the
other direction.
I think the drm_* functions are just an unnecessary extra layer on top
of the core kernel functions and should probably be removed sooner or
later because of midlayering.
Regards,
Christian.
>
> Thank You,
>
> Suraj Upadhyay.
>
> [1] https://dri.freedesktop.org/docs/drm/gpu/todo.html#convert-logging-to-drm-functions-with-drm-device-paramater
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-09 7:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 16:11 [Proposal] DRM: AMD: Convert logging to drm_* functions Suraj Upadhyay
2020-07-09 7:14 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).