From: tanhuazhong <tanhuazhong@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<linux@armlinux.org.uk>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>, <kuba@kernel.org>,
Yufeng Mo <moyufeng@huawei.com>,
Jian Shen <shenjian15@huawei.com>
Subject: Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F
Date: Thu, 14 May 2020 09:32:51 +0800 [thread overview]
Message-ID: <e54083ee-ed3a-115f-0856-d943dac579a8@huawei.com> (raw)
In-Reply-To: <20200513131226.GA499265@lunn.ch>
On 2020/5/13 21:12, Andrew Lunn wrote:
> On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote:
>> From: Yufeng Mo <moyufeng@huawei.com>
>>
>> PHY loopback is already supported by genphy driver. This patch
>> adds the set_loopback interface to RTL8211F PHY driver, so the PHY
>> selftest can run properly on it.
>>
>> Signed-off-by: Yufeng Mo <moyufeng@huawei.com>
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>
> It took three people to write a 1 line patch?
Yufeng Mo is the author of this patch, since he has not right to send mail
so I just help him to do than。 If necessary, Jian Shen could be deleted.
>
>> ---
>> drivers/net/phy/realtek.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
>> index c7229d0..6c5918c 100644
>> --- a/drivers/net/phy/realtek.c
>> +++ b/drivers/net/phy/realtek.c
>> @@ -615,6 +615,7 @@ static struct phy_driver realtek_drvs[] = {
>> .resume = genphy_resume,
>> .read_page = rtl821x_read_page,
>> .write_page = rtl821x_write_page,
>> + .set_loopback = genphy_loopback,
>> }, {
>> .name = "Generic FE-GE Realtek PHY",
>> .match_phy_device = rtlgen_match_phy_device,
>
> Do you have access to the data sheets? Can you check if the other PHYs
> supported by this driver also support loopback in the standard way?
> They probably do.
>
> Andrew
>
We have checked the data sheet. Since we only have rtl8211f phy on our
hand, so only support loopback on this phy.
Thanks:)
> .
>
next prev parent reply other threads:[~2020-05-14 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 8:25 [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F Huazhong Tan
2020-05-13 13:12 ` Andrew Lunn
2020-05-14 1:32 ` tanhuazhong [this message]
2020-05-18 1:49 ` tanhuazhong
2020-05-18 14:50 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e54083ee-ed3a-115f-0856-d943dac579a8@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxarm@huawei.com \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).