* [PATCH] mailbox: mediatek: add module license
@ 2018-08-13 21:44 Arnd Bergmann
2018-08-13 22:50 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-08-13 21:44 UTC (permalink / raw)
To: Jassi Brar, Matthias Brugger
Cc: Arnd Bergmann, HS Liao, CK Hu, Houlong Wei, linux-kernel,
linux-arm-kernel, linux-mediatek
The missing license tag in the new driver causes a compile-time warning,
and may result in the module being unusable if it calls EXPORT_SYMBOL_GPL()
functions:
WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox/mtk-cmdq-mailbox.o
Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/mailbox/mtk-cmdq-mailbox.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 6f92c5ee12f7..aec46d5d3506 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -567,3 +567,5 @@ static void __exit cmdq_drv_exit(void)
subsys_initcall(cmdq_drv_init);
module_exit(cmdq_drv_exit);
+
+MODULE_LICENSE("GPL v2");
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mailbox: mediatek: add module license
2018-08-13 21:44 [PATCH] mailbox: mediatek: add module license Arnd Bergmann
@ 2018-08-13 22:50 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2018-08-13 22:50 UTC (permalink / raw)
To: Arnd Bergmann, Jassi Brar, Matthias Brugger
Cc: HS Liao, CK Hu, Houlong Wei, linux-kernel, linux-arm-kernel,
linux-mediatek
On 08/13/2018 02:44 PM, Arnd Bergmann wrote:
> The missing license tag in the new driver causes a compile-time warning,
> and may result in the module being unusable if it calls EXPORT_SYMBOL_GPL()
> functions:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox/mtk-cmdq-mailbox.o
>
> Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 6f92c5ee12f7..aec46d5d3506 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -567,3 +567,5 @@ static void __exit cmdq_drv_exit(void)
>
> subsys_initcall(cmdq_drv_init);
> module_exit(cmdq_drv_exit);
> +
> +MODULE_LICENSE("GPL v2");
>
https://lore.kernel.org/lkml/99f4666b-95fc-a1dd-04d3-3d1d803990fb@infradead.org/
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-13 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-13 21:44 [PATCH] mailbox: mediatek: add module license Arnd Bergmann
2018-08-13 22:50 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).