From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Lee Jones <lee@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: tlc591xx: Mark OF related data as maybe unused
Date: Sun, 12 Mar 2023 11:21:44 +0100 [thread overview]
Message-ID: <e62cfcf5-e43a-ee14-f290-9004818df839@linaro.org> (raw)
In-Reply-To: <ZAxnl9zn/IrHMx9S@duo.ucw.cz>
On 11/03/2023 12:35, Pavel Machek wrote:
> On Sat 2023-03-11 12:17:17, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>> drivers/leds/leds-tlc591xx.c:138:34: error: ‘of_tlc591xx_leds_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
I was thinking you will take it... or the Ack is for Lee then?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-12 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:17 [PATCH] leds: tlc591xx: Mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 11:35 ` Pavel Machek
2023-03-12 10:21 ` Krzysztof Kozlowski [this message]
2023-03-12 19:23 ` Pavel Machek
2023-03-13 17:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e62cfcf5-e43a-ee14-f290-9004818df839@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).