* [PATCH] leds: tlc591xx: Mark OF related data as maybe unused
@ 2023-03-11 11:17 Krzysztof Kozlowski
2023-03-11 11:35 ` Pavel Machek
2023-03-13 17:10 ` Lee Jones
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-11 11:17 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, linux-leds, linux-kernel; +Cc: Krzysztof Kozlowski
The driver can be compile tested with !CONFIG_OF making certain data
unused:
drivers/leds/leds-tlc591xx.c:138:34: error: ‘of_tlc591xx_leds_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/leds/leds-tlc591xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index ec25e0c16bea..7e31db50036f 100644
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -135,7 +135,7 @@ static const struct regmap_config tlc591xx_regmap = {
.max_register = 0x1e,
};
-static const struct of_device_id of_tlc591xx_leds_match[] = {
+static const struct of_device_id of_tlc591xx_leds_match[] __maybe_unused = {
{ .compatible = "ti,tlc59116",
.data = &tlc59116 },
{ .compatible = "ti,tlc59108",
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] leds: tlc591xx: Mark OF related data as maybe unused
2023-03-11 11:17 [PATCH] leds: tlc591xx: Mark OF related data as maybe unused Krzysztof Kozlowski
@ 2023-03-11 11:35 ` Pavel Machek
2023-03-12 10:21 ` Krzysztof Kozlowski
2023-03-13 17:10 ` Lee Jones
1 sibling, 1 reply; 5+ messages in thread
From: Pavel Machek @ 2023-03-11 11:35 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Lee Jones, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
On Sat 2023-03-11 12:17:17, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/leds/leds-tlc591xx.c:138:34: error: ‘of_tlc591xx_leds_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] leds: tlc591xx: Mark OF related data as maybe unused
2023-03-11 11:35 ` Pavel Machek
@ 2023-03-12 10:21 ` Krzysztof Kozlowski
2023-03-12 19:23 ` Pavel Machek
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-12 10:21 UTC (permalink / raw)
To: Pavel Machek; +Cc: Lee Jones, linux-leds, linux-kernel
On 11/03/2023 12:35, Pavel Machek wrote:
> On Sat 2023-03-11 12:17:17, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>> drivers/leds/leds-tlc591xx.c:138:34: error: ‘of_tlc591xx_leds_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
I was thinking you will take it... or the Ack is for Lee then?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] leds: tlc591xx: Mark OF related data as maybe unused
2023-03-12 10:21 ` Krzysztof Kozlowski
@ 2023-03-12 19:23 ` Pavel Machek
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Machek @ 2023-03-12 19:23 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Lee Jones, linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Sun 2023-03-12 11:21:44, Krzysztof Kozlowski wrote:
> On 11/03/2023 12:35, Pavel Machek wrote:
> > On Sat 2023-03-11 12:17:17, Krzysztof Kozlowski wrote:
> >> The driver can be compile tested with !CONFIG_OF making certain data
> >> unused:
> >>
> >> drivers/leds/leds-tlc591xx.c:138:34: error: ‘of_tlc591xx_leds_match’ defined but not used [-Werror=unused-const-variable=]
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Acked-by: Pavel Machek <pavel@ucw.cz>
>
> I was thinking you will take it... or the Ack is for Lee then?
Me or Lee will take it, depending on workload.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] leds: tlc591xx: Mark OF related data as maybe unused
2023-03-11 11:17 [PATCH] leds: tlc591xx: Mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 11:35 ` Pavel Machek
@ 2023-03-13 17:10 ` Lee Jones
1 sibling, 0 replies; 5+ messages in thread
From: Lee Jones @ 2023-03-13 17:10 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Pavel Machek, linux-leds, linux-kernel
On Sat, 11 Mar 2023, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
>
> drivers/leds/leds-tlc591xx.c:138:34: error: ‘of_tlc591xx_leds_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/leds/leds-tlc591xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-13 17:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 11:17 [PATCH] leds: tlc591xx: Mark OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 11:35 ` Pavel Machek
2023-03-12 10:21 ` Krzysztof Kozlowski
2023-03-12 19:23 ` Pavel Machek
2023-03-13 17:10 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).