* mainline build failure due to 6b47441bed49 ("watchdog: hpe-wdt: Introduce HPE GXP Watchdog")
@ 2022-06-03 10:02 Sudip Mukherjee
2022-06-03 13:15 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Sudip Mukherjee @ 2022-06-03 10:02 UTC (permalink / raw)
To: Nick Hawkins
Cc: Arnd Bergmann, Guenter Roeck, Jean-Marie Verdun,
Wim Van Sebroeck, linux-watchdog, linux-kernel, torvalds
Hi All,
The latest mainline kernel branch fails to build for "arm allmodconfig"
with the error:
ERROR: modpost: missing MODULE_LICENSE() in drivers/watchdog/gxp-wdt.o
make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
The file is missing MODULE_LICENSE().
--
Regards
Sudip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mainline build failure due to 6b47441bed49 ("watchdog: hpe-wdt: Introduce HPE GXP Watchdog")
2022-06-03 10:02 mainline build failure due to 6b47441bed49 ("watchdog: hpe-wdt: Introduce HPE GXP Watchdog") Sudip Mukherjee
@ 2022-06-03 13:15 ` Guenter Roeck
2022-06-03 15:29 ` Hawkins, Nick
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2022-06-03 13:15 UTC (permalink / raw)
To: Sudip Mukherjee, Nick Hawkins
Cc: Arnd Bergmann, Jean-Marie Verdun, Wim Van Sebroeck,
linux-watchdog, linux-kernel, torvalds
On 6/3/22 03:02, Sudip Mukherjee wrote:
> Hi All,
>
> The latest mainline kernel branch fails to build for "arm allmodconfig"
> with the error:
> ERROR: modpost: missing MODULE_LICENSE() in drivers/watchdog/gxp-wdt.o
> make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
>
> The file is missing MODULE_LICENSE().
>
I sent a patch fixing the problem a minute ago.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: mainline build failure due to 6b47441bed49 ("watchdog: hpe-wdt: Introduce HPE GXP Watchdog")
2022-06-03 13:15 ` Guenter Roeck
@ 2022-06-03 15:29 ` Hawkins, Nick
2022-06-03 15:51 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Hawkins, Nick @ 2022-06-03 15:29 UTC (permalink / raw)
To: Guenter Roeck, Sudip Mukherjee
Cc: Arnd Bergmann, Verdun, Jean-Marie, Wim Van Sebroeck,
linux-watchdog, linux-kernel, torvalds
> I sent a patch fixing the problem a minute ago.
Thank you for correcting this. I had the compiler set to W=1, is there another option I should be using to catch errors like this?
-Nick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mainline build failure due to 6b47441bed49 ("watchdog: hpe-wdt: Introduce HPE GXP Watchdog")
2022-06-03 15:29 ` Hawkins, Nick
@ 2022-06-03 15:51 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2022-06-03 15:51 UTC (permalink / raw)
To: Hawkins, Nick, Sudip Mukherjee
Cc: Arnd Bergmann, Verdun, Jean-Marie, Wim Van Sebroeck,
linux-watchdog, linux-kernel, torvalds
On 6/3/22 08:29, Hawkins, Nick wrote:
>> I sent a patch fixing the problem a minute ago.
>
> Thank you for correcting this. I had the compiler set to W=1, is there another option I should be using to catch errors like this?
>
arm:allmodconfig reproduces the problem. I had seen it as well,
which is why I sent a fix. The key is to enable -Werror
(CONFIG_WERROR=y), not W=1.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-03 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-03 10:02 mainline build failure due to 6b47441bed49 ("watchdog: hpe-wdt: Introduce HPE GXP Watchdog") Sudip Mukherjee
2022-06-03 13:15 ` Guenter Roeck
2022-06-03 15:29 ` Hawkins, Nick
2022-06-03 15:51 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).