* [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent
@ 2019-07-15 3:20 Fuqian Huang
2019-07-15 10:40 ` Emil Velikov
0 siblings, 1 reply; 3+ messages in thread
From: Fuqian Huang @ 2019-07-15 3:20 UTC (permalink / raw)
Cc: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel,
Fuqian Huang
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
Changes in v3:
- Use actual commit rather than the merge commit in the commit message
drivers/video/fbdev/mmp/fb/mmpfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/mmp/fb/mmpfb.c b/drivers/video/fbdev/mmp/fb/mmpfb.c
index e5b56f2199df..47bc7c59bbd8 100644
--- a/drivers/video/fbdev/mmp/fb/mmpfb.c
+++ b/drivers/video/fbdev/mmp/fb/mmpfb.c
@@ -612,7 +612,6 @@ static int mmpfb_probe(struct platform_device *pdev)
ret = -ENOMEM;
goto failed_destroy_mutex;
}
- memset(fbi->fb_start, 0, fbi->fb_size);
dev_info(fbi->dev, "fb %dk allocated\n", fbi->fb_size/1024);
/* fb power on */
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent
2019-07-15 3:20 [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent Fuqian Huang
@ 2019-07-15 10:40 ` Emil Velikov
2019-07-23 15:37 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Emil Velikov @ 2019-07-15 10:40 UTC (permalink / raw)
To: Fuqian Huang
Cc: linux-fbdev, linux-kernel, dri-devel, Bartlomiej Zolnierkiewicz
On 2019/07/15, Fuqian Huang wrote:
> In commit 518a2f1925c3
> ("dma-mapping: zero memory returned from dma_alloc_*"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> Changes in v3:
> - Use actual commit rather than the merge commit in the commit message
>
> drivers/video/fbdev/mmp/fb/mmpfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
-Emil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent
2019-07-15 10:40 ` Emil Velikov
@ 2019-07-23 15:37 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-07-23 15:37 UTC (permalink / raw)
To: Emil Velikov, Fuqian Huang; +Cc: linux-fbdev, linux-kernel, dri-devel
On 7/15/19 12:40 PM, Emil Velikov wrote:
> On 2019/07/15, Fuqian Huang wrote:
>> In commit 518a2f1925c3
>> ("dma-mapping: zero memory returned from dma_alloc_*"),
>> dma_alloc_coherent has already zeroed the memory.
>> So memset is not needed.
>>
>> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
>> ---
>> Changes in v3:
>> - Use actual commit rather than the merge commit in the commit message
>>
>> drivers/video/fbdev/mmp/fb/mmpfb.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Patch queued for v5.4, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-23 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-15 3:20 [PATCH v3 24/24] video: fbdev-MMP: Remove call to memset after dma_alloc_coherent Fuqian Huang
2019-07-15 10:40 ` Emil Velikov
2019-07-23 15:37 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).