* [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"
@ 2020-03-17 6:28 Amy.Shih
2020-03-20 1:54 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Amy.Shih @ 2020-03-17 6:28 UTC (permalink / raw)
To: she90122
Cc: Tony Luck, Borislav Petkov, Mauro Carvalho Chehab, James Morse,
Robert Richter, linux-edac, linux-kernel, amy.shih, oakley.ding
From: Amy Shih <amy.shih@advantech.com.tw>
Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to
register device with error %d", since it is not the error message but
the information to notice the user.
Signed-off-by: Amy Shih <amy.shih@advantech.com.tw>
---
drivers/edac/pnd2_edac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 933f772..f15d3b4 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
rc = pnd2_probe();
if (rc < 0) {
- pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
+ pnd2_printk(KERN_INFO,
+ "Failed to register device with error %d.\n", rc);
return rc;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d"
2020-03-17 6:28 [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d" Amy.Shih
@ 2020-03-20 1:54 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-03-20 1:54 UTC (permalink / raw)
To: Amy.Shih, she90122
Cc: Tony Luck, Borislav Petkov, Mauro Carvalho Chehab, James Morse,
Robert Richter, linux-edac, linux-kernel, oakley.ding
On Tue, 2020-03-17 at 06:28 +0000, Amy.Shih@advantech.com.tw wrote:
> From: Amy Shih <amy.shih@advantech.com.tw>
>
> Fix the log level from "KERN_ERR" to "KERN_INFO" for message "Failed to
> register device with error %d", since it is not the error message but
> the information to notice the user.
[]
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
[]
> @@ -1572,7 +1572,8 @@ static int __init pnd2_init(void)
>
> rc = pnd2_probe();
> if (rc < 0) {
> - pnd2_printk(KERN_ERR, "Failed to register device with error %d.\n", rc);
> + pnd2_printk(KERN_INFO,
> + "Failed to register device with error %d.\n", rc);
So there's no need to use the word "error"
in the output message either.
"Failed to register device - %d\n", rc
would be enough.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-20 1:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 6:28 [v1,1/1] EDAC: (pnd2) Fix the log level for message "Failed to register device with error %d" Amy.Shih
2020-03-20 1:54 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).