* [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee
@ 2020-01-16 15:48 Colin King
2020-01-17 6:40 ` Thomas, Rijo-john
2020-01-22 10:14 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Colin King @ 2020-01-16 15:48 UTC (permalink / raw)
To: Jens Wiklander, Devaraj Rangasamy, Gary R Hook, Herbert Xu,
Rijo Thomas, linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the memory allocation failure checks on drv_data and
amdtee are using IS_ERR rather than checking for a null pointer.
Fix these checks to use the conventional null pointer check.
Addresses-Coverity: ("Dereference null return")
Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
V2: update to apply against cryptodev-2.6 tree tip
---
drivers/tee/amdtee/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
index be8937eb5d43..6370bb55f512 100644
--- a/drivers/tee/amdtee/core.c
+++ b/drivers/tee/amdtee/core.c
@@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
}
drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
- if (IS_ERR(drv_data))
+ if (!drv_data)
return -ENOMEM;
amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
- if (IS_ERR(amdtee)) {
+ if (!amdtee) {
rc = -ENOMEM;
goto err_kfree_drv_data;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee
2020-01-16 15:48 [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee Colin King
@ 2020-01-17 6:40 ` Thomas, Rijo-john
2020-01-17 12:16 ` Jens Wiklander
2020-01-22 10:14 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Thomas, Rijo-john @ 2020-01-17 6:40 UTC (permalink / raw)
To: Colin King, Jens Wiklander, Devaraj Rangasamy, Gary R Hook,
Herbert Xu, linux-crypto
Cc: kernel-janitors, linux-kernel
On 16/01/20 9:18 pm, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the memory allocation failure checks on drv_data and
> amdtee are using IS_ERR rather than checking for a null pointer.
> Fix these checks to use the conventional null pointer check.
>
> Addresses-Coverity: ("Dereference null return")
> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Thanks,
Rijo
> ---
> V2: update to apply against cryptodev-2.6 tree tip
> ---
> drivers/tee/amdtee/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> index be8937eb5d43..6370bb55f512 100644
> --- a/drivers/tee/amdtee/core.c
> +++ b/drivers/tee/amdtee/core.c
> @@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
> }
>
> drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> - if (IS_ERR(drv_data))
> + if (!drv_data)
> return -ENOMEM;
>
> amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
> - if (IS_ERR(amdtee)) {
> + if (!amdtee) {
> rc = -ENOMEM;
> goto err_kfree_drv_data;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee
2020-01-17 6:40 ` Thomas, Rijo-john
@ 2020-01-17 12:16 ` Jens Wiklander
0 siblings, 0 replies; 4+ messages in thread
From: Jens Wiklander @ 2020-01-17 12:16 UTC (permalink / raw)
To: Thomas, Rijo-john
Cc: Colin King, Devaraj Rangasamy, Gary R Hook, Herbert Xu,
open list:HARDWARE RANDOM NUMBER GENERATOR CORE, kernel-janitors,
Linux Kernel Mailing List
On Fri, Jan 17, 2020 at 7:40 AM Thomas, Rijo-john
<Rijo-john.Thomas@amd.com> wrote:
>
>
>
> On 16/01/20 9:18 pm, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the memory allocation failure checks on drv_data and
> > amdtee are using IS_ERR rather than checking for a null pointer.
> > Fix these checks to use the conventional null pointer check.
> >
> > Addresses-Coverity: ("Dereference null return")
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Thanks,
Jens
>
> Thanks,
> Rijo
>
> > ---
> > V2: update to apply against cryptodev-2.6 tree tip
> > ---
> > drivers/tee/amdtee/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> > index be8937eb5d43..6370bb55f512 100644
> > --- a/drivers/tee/amdtee/core.c
> > +++ b/drivers/tee/amdtee/core.c
> > @@ -446,11 +446,11 @@ static int __init amdtee_driver_init(void)
> > }
> >
> > drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> > - if (IS_ERR(drv_data))
> > + if (!drv_data)
> > return -ENOMEM;
> >
> > amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
> > - if (IS_ERR(amdtee)) {
> > + if (!amdtee) {
> > rc = -ENOMEM;
> > goto err_kfree_drv_data;
> > }
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee
2020-01-16 15:48 [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee Colin King
2020-01-17 6:40 ` Thomas, Rijo-john
@ 2020-01-22 10:14 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-01-22 10:14 UTC (permalink / raw)
To: Colin King
Cc: Jens Wiklander, Devaraj Rangasamy, Gary R Hook, Rijo Thomas,
linux-crypto, kernel-janitors, linux-kernel
On Thu, Jan 16, 2020 at 03:48:52PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the memory allocation failure checks on drv_data and
> amdtee are using IS_ERR rather than checking for a null pointer.
> Fix these checks to use the conventional null pointer check.
>
> Addresses-Coverity: ("Dereference null return")
> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> V2: update to apply against cryptodev-2.6 tree tip
> ---
> drivers/tee/amdtee/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-22 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 15:48 [PATCH][next][V2] tee: fix memory allocation failure checks on drv_data and amdtee Colin King
2020-01-17 6:40 ` Thomas, Rijo-john
2020-01-17 12:16 ` Jens Wiklander
2020-01-22 10:14 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).