* [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include
@ 2023-01-23 20:18 Krzysztof Kozlowski
2023-01-23 20:18 ` [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents Krzysztof Kozlowski
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 20:18 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Dmitry Baryshkov, linux-arm-msm, linux-clk,
linux-kernel
Cc: Krzysztof Kozlowski
Include asm/cputype.h to fix ARMv7 compile test error:
drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’:
drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/clk/qcom/clk-cpu-8996.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
index ee76ef958d31..40c4dabc20a7 100644
--- a/drivers/clk/qcom/clk-cpu-8996.c
+++ b/drivers/clk/qcom/clk-cpu-8996.c
@@ -49,6 +49,7 @@
* detect voltage droops.
*/
+#include <asm/cputype.h>
#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/clk-provider.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents
2023-01-23 20:18 [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Krzysztof Kozlowski
@ 2023-01-23 20:18 ` Krzysztof Kozlowski
2023-01-23 20:28 ` Konrad Dybcio
2023-01-25 20:33 ` Stephen Boyd
2023-01-23 20:18 ` [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment Krzysztof Kozlowski
` (3 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 20:18 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Dmitry Baryshkov, linux-arm-msm, linux-clk,
linux-kernel
Cc: Krzysztof Kozlowski
num_parents field is being initialized twice:
gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/clk/qcom/gcc-qcs404.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index 5f58dd82d3fe..a39c4990b29d 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
.name = "cxo",
.parent_data = gcc_parent_data_1,
.num_parents = ARRAY_SIZE(gcc_parent_data_1),
- .num_parents = 1,
.ops = &clk_fixed_factor_ops,
},
};
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment
2023-01-23 20:18 [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Krzysztof Kozlowski
2023-01-23 20:18 ` [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents Krzysztof Kozlowski
@ 2023-01-23 20:18 ` Krzysztof Kozlowski
2023-01-23 20:29 ` Konrad Dybcio
2023-01-25 20:34 ` Stephen Boyd
2023-01-23 20:28 ` [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Konrad Dybcio
` (2 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-23 20:18 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Dmitry Baryshkov, linux-arm-msm, linux-clk,
linux-kernel
Cc: Krzysztof Kozlowski
RPMH_IPA_CLK is assigned twice:
drivers/clk/qcom/clk-rpmh.c:578:35: error: initialized field overwritten [-Werror=override-init]
Fixes: aa055bf158cd ("clk: qcom: rpmh: define IPA clocks where required")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/clk/qcom/clk-rpmh.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
index 393b83f6020e..45ee370f3307 100644
--- a/drivers/clk/qcom/clk-rpmh.c
+++ b/drivers/clk/qcom/clk-rpmh.c
@@ -575,7 +575,6 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
[RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
[RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
[RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
- [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
};
static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include
2023-01-23 20:18 [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Krzysztof Kozlowski
2023-01-23 20:18 ` [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents Krzysztof Kozlowski
2023-01-23 20:18 ` [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment Krzysztof Kozlowski
@ 2023-01-23 20:28 ` Konrad Dybcio
2023-01-25 20:33 ` Stephen Boyd
2023-02-09 4:23 ` (subset) " Bjorn Andersson
4 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2023-01-23 20:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Andy Gross,
Michael Turquette, Stephen Boyd, Dmitry Baryshkov, linux-arm-msm,
linux-clk, linux-kernel
On 23.01.2023 21:18, Krzysztof Kozlowski wrote:
> Include asm/cputype.h to fix ARMv7 compile test error:
>
> drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’:
> drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/clk/qcom/clk-cpu-8996.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
> index ee76ef958d31..40c4dabc20a7 100644
> --- a/drivers/clk/qcom/clk-cpu-8996.c
> +++ b/drivers/clk/qcom/clk-cpu-8996.c
> @@ -49,6 +49,7 @@
> * detect voltage droops.
> */
>
> +#include <asm/cputype.h>
> #include <linux/bitfield.h>
> #include <linux/clk.h>
> #include <linux/clk-provider.h>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents
2023-01-23 20:18 ` [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents Krzysztof Kozlowski
@ 2023-01-23 20:28 ` Konrad Dybcio
2023-01-25 20:33 ` Stephen Boyd
1 sibling, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2023-01-23 20:28 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Andy Gross,
Michael Turquette, Stephen Boyd, Dmitry Baryshkov, linux-arm-msm,
linux-clk, linux-kernel
On 23.01.2023 21:18, Krzysztof Kozlowski wrote:
> num_parents field is being initialized twice:
>
> gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
>
> Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/clk/qcom/gcc-qcs404.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> index 5f58dd82d3fe..a39c4990b29d 100644
> --- a/drivers/clk/qcom/gcc-qcs404.c
> +++ b/drivers/clk/qcom/gcc-qcs404.c
> @@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
> .name = "cxo",
> .parent_data = gcc_parent_data_1,
> .num_parents = ARRAY_SIZE(gcc_parent_data_1),
> - .num_parents = 1,
> .ops = &clk_fixed_factor_ops,
> },
> };
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment
2023-01-23 20:18 ` [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment Krzysztof Kozlowski
@ 2023-01-23 20:29 ` Konrad Dybcio
2023-01-25 20:34 ` Stephen Boyd
1 sibling, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2023-01-23 20:29 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Andy Gross,
Michael Turquette, Stephen Boyd, Dmitry Baryshkov, linux-arm-msm,
linux-clk, linux-kernel
On 23.01.2023 21:18, Krzysztof Kozlowski wrote:
> RPMH_IPA_CLK is assigned twice:
>
> drivers/clk/qcom/clk-rpmh.c:578:35: error: initialized field overwritten [-Werror=override-init]
>
> Fixes: aa055bf158cd ("clk: qcom: rpmh: define IPA clocks where required")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=19aeacf505a08ae8fc1e087f9d85b7caf29b09b4
Konrad
> drivers/clk/qcom/clk-rpmh.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> index 393b83f6020e..45ee370f3307 100644
> --- a/drivers/clk/qcom/clk-rpmh.c
> +++ b/drivers/clk/qcom/clk-rpmh.c
> @@ -575,7 +575,6 @@ static struct clk_hw *sc8280xp_rpmh_clocks[] = {
> [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> [RPMH_PKA_CLK] = &clk_rpmh_pka.hw,
> [RPMH_HWKM_CLK] = &clk_rpmh_hwkm.hw,
> - [RPMH_IPA_CLK] = &clk_rpmh_ipa.hw,
> };
>
> static const struct clk_rpmh_desc clk_rpmh_sc8280xp = {
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include
2023-01-23 20:18 [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-01-23 20:28 ` [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Konrad Dybcio
@ 2023-01-25 20:33 ` Stephen Boyd
2023-01-26 9:32 ` Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) " Bjorn Andersson
4 siblings, 1 reply; 11+ messages in thread
From: Stephen Boyd @ 2023-01-25 20:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Dmitry Baryshkov, Konrad Dybcio,
Krzysztof Kozlowski, Michael Turquette, linux-arm-msm, linux-clk,
linux-kernel
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2023-01-23 12:18:10)
> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
> index ee76ef958d31..40c4dabc20a7 100644
> --- a/drivers/clk/qcom/clk-cpu-8996.c
> +++ b/drivers/clk/qcom/clk-cpu-8996.c
> @@ -49,6 +49,7 @@
> * detect voltage droops.
> */
>
> +#include <asm/cputype.h>
Please include asm headers after linux headers
> #include <linux/bitfield.h>
> #include <linux/clk.h>
> #include <linux/clk-provider.h>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents
2023-01-23 20:18 ` [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents Krzysztof Kozlowski
2023-01-23 20:28 ` Konrad Dybcio
@ 2023-01-25 20:33 ` Stephen Boyd
1 sibling, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2023-01-25 20:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Dmitry Baryshkov, Konrad Dybcio,
Krzysztof Kozlowski, Michael Turquette, linux-arm-msm, linux-clk,
linux-kernel
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2023-01-23 12:18:11)
> num_parents field is being initialized twice:
>
> gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
>
> Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment
2023-01-23 20:18 ` [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment Krzysztof Kozlowski
2023-01-23 20:29 ` Konrad Dybcio
@ 2023-01-25 20:34 ` Stephen Boyd
1 sibling, 0 replies; 11+ messages in thread
From: Stephen Boyd @ 2023-01-25 20:34 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Dmitry Baryshkov, Konrad Dybcio,
Krzysztof Kozlowski, Michael Turquette, linux-arm-msm, linux-clk,
linux-kernel
Cc: Krzysztof Kozlowski
Quoting Krzysztof Kozlowski (2023-01-23 12:18:12)
> RPMH_IPA_CLK is assigned twice:
>
> drivers/clk/qcom/clk-rpmh.c:578:35: error: initialized field overwritten [-Werror=override-init]
>
> Fixes: aa055bf158cd ("clk: qcom: rpmh: define IPA clocks where required")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include
2023-01-25 20:33 ` Stephen Boyd
@ 2023-01-26 9:32 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-26 9:32 UTC (permalink / raw)
To: Stephen Boyd, Andy Gross, Bjorn Andersson, Dmitry Baryshkov,
Konrad Dybcio, Michael Turquette, linux-arm-msm, linux-clk,
linux-kernel
On 25/01/2023 21:33, Stephen Boyd wrote:
> Quoting Krzysztof Kozlowski (2023-01-23 12:18:10)
>> diff --git a/drivers/clk/qcom/clk-cpu-8996.c b/drivers/clk/qcom/clk-cpu-8996.c
>> index ee76ef958d31..40c4dabc20a7 100644
>> --- a/drivers/clk/qcom/clk-cpu-8996.c
>> +++ b/drivers/clk/qcom/clk-cpu-8996.c
>> @@ -49,6 +49,7 @@
>> * detect voltage droops.
>> */
>>
>> +#include <asm/cputype.h>
>
> Please include asm headers after linux headers
Ack
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include
2023-01-23 20:18 [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-01-25 20:33 ` Stephen Boyd
@ 2023-02-09 4:23 ` Bjorn Andersson
4 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:23 UTC (permalink / raw)
To: Andy Gross, Dmitry Baryshkov, Krzysztof Kozlowski, Konrad Dybcio,
linux-clk, Michael Turquette, linux-kernel, Stephen Boyd,
linux-arm-msm
On Mon, 23 Jan 2023 21:18:10 +0100, Krzysztof Kozlowski wrote:
> Include asm/cputype.h to fix ARMv7 compile test error:
>
> drivers/clk/qcom/clk-cpu-8996.c: In function ‘qcom_cpu_clk_msm8996_acd_init’:
> drivers/clk/qcom/clk-cpu-8996.c:468:16: error: implicit declaration of function ‘read_cpuid_mpidr’ [-Werror=implicit-function-declaration]
>
>
Applied, thanks!
[1/3] clk: qcom: cpu-8996: add missing cputype include
commit: 5930196eec0d5dc454db6418d82dcfb094c93373
[2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents
(no commit info)
[3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment
(no commit info)
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-02-09 4:31 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 20:18 [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Krzysztof Kozlowski
2023-01-23 20:18 ` [PATCH 2/3] clk: qcom: gcc-qcs404: fix duplicated num_parents Krzysztof Kozlowski
2023-01-23 20:28 ` Konrad Dybcio
2023-01-25 20:33 ` Stephen Boyd
2023-01-23 20:18 ` [PATCH 3/3] clk: qcom: rpmh: fix double RPMH_IPA_CLK assignment Krzysztof Kozlowski
2023-01-23 20:29 ` Konrad Dybcio
2023-01-25 20:34 ` Stephen Boyd
2023-01-23 20:28 ` [PATCH 1/3] clk: qcom: cpu-8996: add missing cputype include Konrad Dybcio
2023-01-25 20:33 ` Stephen Boyd
2023-01-26 9:32 ` Krzysztof Kozlowski
2023-02-09 4:23 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).