[PATCH] i40e: mark expected switch fall-through

[PATCH] i40e: mark expected switch fall-through

[Gustavo A. R. Silva]

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1473099 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 94947a8..a6f50f6 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -300,9 +300,10 @@ static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
 		break;
 	default:
 		bpf_warn_invalid_xdp_action(act);
+		/* fall through */
 	case XDP_ABORTED:
 		trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
-		/* fallthrough -- handle aborts by dropping packet */
+		/* fall through -- handle aborts by dropping packet */
 	case XDP_DROP:
 		result = I40E_XDP_CONSUMED;
 		break;
-- 
2.7.4

RE: [PATCH] i40e: mark expected switch fall-through

[Kirsher, Jeffrey T]

> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
> Sent: Thursday, August 30, 2018 11:50
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
> <davem@davemloft.net>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH] i40e: mark expected switch fall-through
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
> we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1473099 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I have picked this up Dave.

Re: [PATCH] i40e: mark expected switch fall-through

[Gustavo A. R. Silva]

On 8/30/18 4:09 PM, Kirsher, Jeffrey T wrote:
>> -----Original Message-----
>> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
>> Sent: Thursday, August 30, 2018 11:50
>> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
>> <davem@davemloft.net>
>> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
>> Subject: [PATCH] i40e: mark expected switch fall-through
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
>> we are expecting to fall through.
>>
>> Addresses-Coverity-ID: 1473099 ("Missing break in switch")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I have picked this up Dave.
> 

Thanks, Jeffrey.
--
Gustavo