From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Georgi Djakov <djakov@kernel.org>, Leo Yan <leo.yan@linaro.org>,
Evan Green <evgreen@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings
Date: Wed, 14 Jun 2023 18:43:58 +0200 [thread overview]
Message-ID: <e7a083f6-e885-113b-bb6c-d20108777c5e@linaro.org> (raw)
In-Reply-To: <c8573d08-d4e2-41a8-f0b1-e1d7a0c9ce17@linaro.org>
On 14.06.2023 18:43, Krzysztof Kozlowski wrote:
> On 14/06/2023 12:22, Konrad Dybcio wrote:
>> The SMD RPM interconnect driver requires different icc tags to the
>> RPMh driver. Add bindings to reflect that.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> include/dt-bindings/interconnect/qcom,rpm-icc.h | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> diff --git a/include/dt-bindings/interconnect/qcom,rpm-icc.h b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>> new file mode 100644
>> index 000000000000..2cd56f91e5c5
>> --- /dev/null
>> +++ b/include/dt-bindings/interconnect/qcom,rpm-icc.h
>> @@ -0,0 +1,13 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>> +/*
>> + * Copyright (c) 2023, Linaro Limited
>> + */
>> +
>> +#ifndef __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>> +#define __DT_BINDINGS_INTERCONNECT_QCOM_RPM_ICC_H
>> +
>> +#define RPM_ACTIVE_TAG (1 << 0)
>> +#define RPM_SLEEP_TAG (1 << 1)
>> +#define RPM_ALWAYS_TAG (RPM_ACTIVE_TAG | RPM_SLEEP_TAG)
>
> Where are these used? I don't see any DTS in your patchset. Did you send
> it separately?
In the driver for now, e.g. patch 19. DTS can only come after the
driver is fixed or things will explode!
Konrad
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-06-14 16:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:22 [PATCH v5 00/22] Restructure RPM SMD ICC Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings Konrad Dybcio
2023-06-14 16:43 ` Krzysztof Kozlowski
2023-06-14 16:43 ` Konrad Dybcio [this message]
2023-06-14 16:47 ` Krzysztof Kozlowski
2023-06-14 16:48 ` Konrad Dybcio
2023-06-14 16:52 ` Krzysztof Kozlowski
2023-06-14 16:52 ` Krzysztof Kozlowski
2023-06-14 10:22 ` [PATCH v5 02/22] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 03/22] soc: qcom: smd-rpm: Use tabs for defines Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 04/22] clk: qcom: smd-rpm: Move some RPM resources to the common header Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 05/22] soc: qcom: smd-rpm: Move icc_smd_rpm registration to clk-smd-rpm Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 06/22] interconnect: qcom: icc-rpm: Introduce keep_alive Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 07/22] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 08/22] interconnect: qcom: smd-rpm: Add rpmcc handling skeleton code Konrad Dybcio
2023-06-14 14:47 ` Stephan Gerhold
2023-06-14 17:40 ` Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 09/22] interconnect: qcom: Add missing headers in icc-rpm.h Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 10/22] interconnect: qcom: Define RPM bus clocks Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 11/22] interconnect: qcom: sdm660: Hook up RPM bus clk definitions Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 12/22] interconnect: qcom: msm8996: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 13/22] interconnect: qcom: qcs404: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 14/22] interconnect: qcom: msm8939: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 15/22] interconnect: qcom: msm8916: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 16/22] interconnect: qcom: qcm2290: " Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 17/22] interconnect: qcom: icc-rpm: Control bus rpmcc from icc Konrad Dybcio
2023-06-14 14:49 ` Stephan Gerhold
2023-06-14 10:22 ` [PATCH v5 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 19/22] interconnect: qcom: icc-rpm: Fix bucket number Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 20/22] interconnect: qcom: icc-rpm: Set bandwidth on both contexts Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 21/22] interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req Konrad Dybcio
2023-06-14 10:22 ` [PATCH v5 22/22] interconnect: qcom: icc-rpm: Fix bandwidth calculations Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a083f6-e885-113b-bb6c-d20108777c5e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=evgreen@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).