From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>
Cc: Kevin Hilman <khilman@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] ARM: dts: Add LEGO MINDSTORMS EV3 dts
Date: Wed, 11 Jan 2017 16:12:52 +0530 [thread overview]
Message-ID: <e8136b8a-b8f7-7b1b-693a-955dc17f1de9@ti.com> (raw)
In-Reply-To: <1483677228-2325-6-git-send-email-david@lechnology.com>
On Friday 06 January 2017 10:03 AM, David Lechner wrote:
> + beeper {
> + compatible = "pwm-beeper";
> + pinctrl-names = "default";
> + pinctrl-0 = <&ehrpwm0b_pins>, <&_pins>;
> + pwms = <&ehrpwm0 1 0 0>;
> + enable-gpios = <&gpio 111 GPIO_ACTIVE_HIGH>;
Since the enable-gpios binding for pwm beeper is still not accepted, can
you drop the property or the node itself (if that makes more sense)?
> +&spi0 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>, <&spi0_cs3_pin>;
> +
> + flash@0 {
> + compatible = "n25q128a13", "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <50000000>;
> + ti,spi-wdelay = <8>;
> +
> + /* Partitions are based on the official firmware from LEGO */
> + partitions {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + partition@0 {
> + label = "U-Boot";
> + reg = <0 0x40000>;
> + };
> +
> + partition@40000 {
> + label = "U-Boot Env";
> + reg = <0x40000 0x10000>;
> + };
> +
> + partition@50000 {
> + label = "Kernel";
> + reg = <0x50000 0x200000>;
> + };
> +
> + partition@250000 {
> + label = "Filesystem";
> + reg = <0x250000 0xa50000>;
> + };
> +
> + partition@cb0000 {
> + label = "Storage";
> + reg = <0xcb0000 0x2f0000>;
> + };
> + };
> + };
> +
> + adc@3 {
> + compatible = "ti-ads7957";
So looks like this works because of_register_spi_device() sets up
modalias of spi device from compatible string. I am fine with it, just
highlighting it here to make sure this is acceptable practice. I did not
really find any precedence for using SPI device name as compatible
property in existing DTS files.
> + reg = <3>;
> + spi-max-frequency = <10000000>;
> + refin-supply = <&adc_ref>;
> + };
Rest of the patch looks good to me.
Thanks,
Sekhar
next prev parent reply other threads:[~2017-01-11 10:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 4:33 [PATCH v2 0/5] Support for LEGO MINDSTORMS EV3 David Lechner
2017-01-06 4:33 ` [PATCH v2 1/5] ARM: davinci_all_defconfig: enable DA8xx pinconf David Lechner
2017-01-09 12:18 ` Sekhar Nori
2017-01-06 4:33 ` [PATCH v2 2/5] ARM: davinci_all_defconfig: Enable PWM modules David Lechner
2017-01-09 12:18 ` Sekhar Nori
2017-01-06 4:33 ` [PATCH v2 3/5] ARM: davinci_all_defconfig: enable iio and ADS7950 David Lechner
2017-01-09 12:29 ` Sekhar Nori
2017-01-10 15:43 ` David Lechner
2017-01-11 8:23 ` Sekhar Nori
2017-01-13 12:24 ` Sekhar Nori
2017-01-13 20:02 ` David Lechner
2017-01-06 4:33 ` [PATCH v2 4/5] ARM: davinci_all_defconfig: enable pwm-beeper David Lechner
2017-01-06 4:33 ` [PATCH v2 5/5] ARM: dts: Add LEGO MINDSTORMS EV3 dts David Lechner
2017-01-06 18:04 ` kbuild test robot
2017-01-11 10:42 ` Sekhar Nori [this message]
2017-01-11 16:25 ` David Lechner
2017-01-12 7:39 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8136b8a-b8f7-7b1b-693a-955dc17f1de9@ti.com \
--to=nsekhar@ti.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).