* [PATCH -next] scsi: mpi3mr: Make some symbols static
@ 2021-06-04 5:11 Yang Yingliang
2021-06-04 5:22 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-06-04 5:11 UTC (permalink / raw)
To: linux-kernel, linux-scsi; +Cc: jejb, martin.petersen
Fix the following warnings:
drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static?
drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static?
drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/scsi/mpi3mr/mpi3mr_os.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
index a54aa009ec5a..52f844fb8175 100644
--- a/drivers/scsi/mpi3mr/mpi3mr_os.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_os.c
@@ -21,14 +21,14 @@ MODULE_LICENSE(MPI3MR_DRIVER_LICENSE);
MODULE_VERSION(MPI3MR_DRIVER_VERSION);
/* Module parameters*/
-int prot_mask = -1;
+static int prot_mask = -1;
module_param(prot_mask, int, 0);
MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07");
-int prot_guard_mask = 3;
+static int prot_guard_mask = 3;
module_param(prot_guard_mask, int, 0);
MODULE_PARM_DESC(prot_guard_mask, " Host protection guard mask, def=3");
-int logging_level;
+static int logging_level;
module_param(logging_level, int, 0);
MODULE_PARM_DESC(logging_level,
" bits for enabling additional logging info (default=0)");
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: mpi3mr: Make some symbols static
2021-06-04 5:11 [PATCH -next] scsi: mpi3mr: Make some symbols static Yang Yingliang
@ 2021-06-04 5:22 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2021-06-04 5:22 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-scsi; +Cc: jejb, martin.petersen
On Fri, 2021-06-04 at 13:11 +0800, Yang Yingliang wrote:
> Fix the following warnings:
>
> drivers/scsi/mpi3mr/mpi3mr_os.c:24:5: warning: symbol 'prot_mask' was not declared. Should it be static?
> drivers/scsi/mpi3mr/mpi3mr_os.c:28:5: warning: symbol 'prot_guard_mask' was not declared. Should it be static?
> drivers/scsi/mpi3mr/mpi3mr_os.c:31:5: warning: symbol 'logging_level' was not declared. Should it be static?
[]
> diff --git a/drivers/scsi/mpi3mr/mpi3mr_os.c b/drivers/scsi/mpi3mr/mpi3mr_os.c
[]
> @@ -21,14 +21,14 @@ MODULE_LICENSE(MPI3MR_DRIVER_LICENSE);
> MODULE_VERSION(MPI3MR_DRIVER_VERSION);
>
>
> /* Module parameters*/
> -int prot_mask = -1;
> +static int prot_mask = -1;
> module_param(prot_mask, int, 0);
> MODULE_PARM_DESC(prot_mask, "Host protection capabilities mask, def=0x07");
drivers/scsi/mpi3mr/mpi3mr_fw.c:extern int prot_mask;
drivers/scsi/mpi3mr/mpi3mr_fw.c: if (prot_mask & (SHOST_DIX_TYPE0_PROTEC>
This should probably be put in a .h file instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-04 5:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 5:11 [PATCH -next] scsi: mpi3mr: Make some symbols static Yang Yingliang
2021-06-04 5:22 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).