* [PATCH] Generate netlink notification when default IPv6 route preference changes
@ 2022-02-09 20:38 Kalash Nainwal
2022-02-10 18:19 ` David Ahern
0 siblings, 1 reply; 2+ messages in thread
From: Kalash Nainwal @ 2022-02-09 20:38 UTC (permalink / raw)
To: netdev
Cc: fruggeri, kalash, David S. Miller, Hideaki YOSHIFUJI,
David Ahern, Jakub Kicinski, linux-kernel
Generate RTM_NEWROUTE netlink notification when the route preference
changes on an existing kernel generated default route in response to
RA messages. Currently netlink notifications are generated only when
this route is added or deleted but not when the route preference
changes, which can cause userspace routing application state to go
out of sync with kernel.
Signed-off-by: Kalash Nainwal <kalash@arista.com>
---
net/ipv6/ndisc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index f03b597e4121..fd14f5b1c767 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1337,8 +1337,12 @@ static void ndisc_router_discovery(struct sk_buff *skb)
return;
}
neigh->flags |= NTF_ROUTER;
- } else if (rt) {
+ } else if (rt && IPV6_EXTRACT_PREF(rt->fib6_flags) != pref) {
+ struct nl_info nlinfo = {
+ .nl_net = net,
+ };
rt->fib6_flags = (rt->fib6_flags & ~RTF_PREF_MASK) | RTF_PREF(pref);
+ inet6_rt_notify(RTM_NEWROUTE, rt, &nlinfo, NLM_F_CREATE);
}
if (rt)
--
2.30.1 (Apple Git-130)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Generate netlink notification when default IPv6 route preference changes
2022-02-09 20:38 [PATCH] Generate netlink notification when default IPv6 route preference changes Kalash Nainwal
@ 2022-02-10 18:19 ` David Ahern
0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2022-02-10 18:19 UTC (permalink / raw)
To: Kalash Nainwal, netdev
Cc: fruggeri, David S. Miller, Hideaki YOSHIFUJI, David Ahern,
Jakub Kicinski, linux-kernel
On 2/9/22 12:38 PM, Kalash Nainwal wrote:
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index f03b597e4121..fd14f5b1c767 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -1337,8 +1337,12 @@ static void ndisc_router_discovery(struct sk_buff *skb)
> return;
> }
> neigh->flags |= NTF_ROUTER;
> - } else if (rt) {
> + } else if (rt && IPV6_EXTRACT_PREF(rt->fib6_flags) != pref) {
> + struct nl_info nlinfo = {
> + .nl_net = net,
> + };
> rt->fib6_flags = (rt->fib6_flags & ~RTF_PREF_MASK) | RTF_PREF(pref);
> + inet6_rt_notify(RTM_NEWROUTE, rt, &nlinfo, NLM_F_CREATE);
> }
>
> if (rt)
route exists, but the flags are updated so that should be NLM_F_REPLACE.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-10 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 20:38 [PATCH] Generate netlink notification when default IPv6 route preference changes Kalash Nainwal
2022-02-10 18:19 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).