From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Zhengyu Shen <zhengyu.shen@nxp.com>, shawnguo@kernel.org
Cc: mark.rutland@arm.com, peterz@infradead.org, frank.li@nxp.com,
linux-kernel@vger.kernel.org, acme@kernel.org,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
lznuaa@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] Added perf functionality to mmdc driver
Date: Wed, 31 Aug 2016 17:20:49 +0100 [thread overview]
Message-ID: <e8a82cd8-0920-9da8-77f7-5245a4d36f89@arm.com> (raw)
In-Reply-To: <20160817194253.16300-1-zhengyu.shen@nxp.com>
On 17/08/16 20:42, Zhengyu Shen wrote:
> MMDC is a multi-mode DDR controller that supports DDR3/DDR3L x16/x32/x64
> and LPDDR2 two channel x16/x32 memory types. MMDC is configurable, high
> performance, and optimized. MMDC is present on i.MX6 Quad and i.MX6
> QuadPlus devices, but this driver only supports i.MX6 Quad at the moment.
> MMDC provides registers for performance counters which read via this
> driver to help debug memory throughput and similar issues.
>
> $ perf stat -a -e mmdc/busy-cycles/,mmdc/read-accesses/,mmdc/read-bytes/,mmdc/total-cycles/,mmdc/write-accesses/,mmdc/write-bytes/ dd if=/dev/zero of=/dev/null bs=1M count=5000
> Performance counter stats for 'dd if=/dev/zero of=/dev/null bs=1M count=5000':
>
> 898021787 mmdc/busy-cycles/
> 14819600 mmdc/read-accesses/
> 471.30 MB mmdc/read-bytes/
> 2815419216 mmdc/total-cycles/
> 13367354 mmdc/write-accesses/
> 427.76 MB mmdc/write-bytes/
>
> 5.334757334 seconds time elapsed
>
> Signed-off-by: Zhengyu Shen <zhengyu.shen@nxp.com>
> Signed-off-by: Frank Li <frank.li@nxp.com>
> +
> +static int mmdc_pmu_init(struct mmdc_pmu *pmu_mmdc,
> + void __iomem *mmdc_base, struct device *dev)
> +{
> + int mmdc_num;
> +
> + *pmu_mmdc = (struct mmdc_pmu) {
> + .pmu = (struct pmu) {
> + .task_ctx_nr = perf_invalid_context,
> + .attr_groups = attr_groups,
> + .event_init = mmdc_event_init,
> + .add = mmdc_event_add,
> + .del = mmdc_event_del,
> + .start = mmdc_event_start,
> + .stop = mmdc_event_stop,
> + .read = mmdc_event_update,
> + },
> + .mmdc_base = mmdc_base,
> + };
> +
> + mmdc_num = ida_simple_get(&mmdc_ida, 0, 0, GFP_KERNEL);
> +
> + cpumask_set_cpu(smp_processor_id(), &pmu_mmdc->cpu);
> +
> + pmu_mmdc->dev = dev;
> + pmu_mmdc->active_events = 0;
> + spin_lock_init(&pmu_mmdc->mmdc_active_events_lock);
> +
> + cpuhp_mmdc_pmu = pmu_mmdc;
> + cpuhp_setup_state(CPUHP_ONLINE,
> + "PERF_MMDC_ONLINE", NULL,
> + mmdc_pmu_offline_cpu);
You may want cpuhp_setup_state_nocalls instead here ?
Cheers
Suzuki
prev parent reply other threads:[~2016-08-31 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 19:42 [PATCH v3] Added perf functionality to mmdc driver Zhengyu Shen
2016-08-29 16:06 ` Zhi Li
2016-08-30 11:43 ` Shawn Guo
2016-08-30 12:54 ` Mark Rutland
2016-08-30 20:01 ` Zhengyu Shen
2016-08-31 10:30 ` Mark Rutland
2016-08-31 13:46 ` Zhengyu Shen
2016-08-30 14:06 ` Shawn Guo
2016-08-31 13:08 ` Suzuki K Poulose
2016-08-31 16:20 ` Suzuki K Poulose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a82cd8-0920-9da8-77f7-5245a4d36f89@arm.com \
--to=suzuki.poulose@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=frank.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shawnguo@kernel.org \
--cc=zhengyu.shen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).