* [PATCH] nds32: add a Kconfig symbol for LOCKDEP_SUPPORT
@ 2021-05-17 3:13 Randy Dunlap
2022-02-17 19:01 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-05-17 3:13 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Nick Hu, Greentime Hu, Vincent Chen, Andrew Morton
Each architecture (arch/) should define its own LOCKDEP_SUPPORT
Kconfig symbol (if it is needed). arch/nds32/ is the only one
that does "select LOCKDEP_SUPPORT", which is basically a no-op
since the symbol is not defined. (It might be nice for kconfig
to warn about that.)
Add a "config LOCKDEP_SUPPORT" to arch/nds32/Kconfig to correct
this issue.
Since the current Kconfig file selects LOCKDEP_SUPPORT unconditionally,
use "def_bool y" to set/enable it always.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Nick Hu <nickhu@andestech.com>
Cc: Greentime Hu <green.hu@gmail.com>
Cc: Vincent Chen <deanbo422@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
arch/nds32/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- linux-next-20210514.orig/arch/nds32/Kconfig
+++ linux-next-20210514/arch/nds32/Kconfig
@@ -36,7 +36,6 @@ config NDS32
select HAVE_REGS_AND_STACK_ACCESS_API
select HAVE_PERF_EVENTS
select IRQ_DOMAIN
- select LOCKDEP_SUPPORT
select MODULES_USE_ELF_RELA
select OF
select OF_EARLY_FLATTREE
@@ -64,6 +63,9 @@ config GENERIC_LOCKBREAK
def_bool y
depends on PREEMPTION
+config LOCKDEP_SUPPORT
+ def_bool y
+
config TRACE_IRQFLAGS_SUPPORT
def_bool y
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nds32: add a Kconfig symbol for LOCKDEP_SUPPORT
2021-05-17 3:13 [PATCH] nds32: add a Kconfig symbol for LOCKDEP_SUPPORT Randy Dunlap
@ 2022-02-17 19:01 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-02-17 19:01 UTC (permalink / raw)
To: linux-kernel
Cc: Nick Hu, Greentime Hu, Vincent Chen, Andrew Morton, Alan Kao, kclin
Add Alan and KC.
On 5/16/21 20:13, Randy Dunlap wrote:
> Each architecture (arch/) should define its own LOCKDEP_SUPPORT
> Kconfig symbol (if it is needed). arch/nds32/ is the only one
> that does "select LOCKDEP_SUPPORT", which is basically a no-op
> since the symbol is not defined. (It might be nice for kconfig
> to warn about that.)
>
> Add a "config LOCKDEP_SUPPORT" to arch/nds32/Kconfig to correct
> this issue.
>
> Since the current Kconfig file selects LOCKDEP_SUPPORT unconditionally,
> use "def_bool y" to set/enable it always.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Nick Hu <nickhu@andestech.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> arch/nds32/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> --- linux-next-20210514.orig/arch/nds32/Kconfig
> +++ linux-next-20210514/arch/nds32/Kconfig
> @@ -36,7 +36,6 @@ config NDS32
> select HAVE_REGS_AND_STACK_ACCESS_API
> select HAVE_PERF_EVENTS
> select IRQ_DOMAIN
> - select LOCKDEP_SUPPORT
> select MODULES_USE_ELF_RELA
> select OF
> select OF_EARLY_FLATTREE
> @@ -64,6 +63,9 @@ config GENERIC_LOCKBREAK
> def_bool y
> depends on PREEMPTION
>
> +config LOCKDEP_SUPPORT
> + def_bool y
> +
> config TRACE_IRQFLAGS_SUPPORT
> def_bool y
>
Anybody out there for Andes?
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-17 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-17 3:13 [PATCH] nds32: add a Kconfig symbol for LOCKDEP_SUPPORT Randy Dunlap
2022-02-17 19:01 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).