* [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
[not found] <CGME20170614063359epcas5p46658bba447468cd367d0684bd9485bf8@epcas5p4.samsung.com>
@ 2017-06-14 6:33 ` Hoegeun Kwon
2017-06-14 12:30 ` Tobias Jakobi
0 siblings, 1 reply; 3+ messages in thread
From: Hoegeun Kwon @ 2017-06-14 6:33 UTC (permalink / raw)
To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk
Cc: javier, a.hajda, tjakobi, dri-devel, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Hoegeun Kwon
Remove the error handling of bridge_node because the bridge_node is
required optionally.
For example, In case of Exynos SoC, a bridge device such as mDNIe and
MIC could be placed between Display Controller and MIPI DSI device but
the bridge device is required optionally.
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
Hi Inki and Tobias,
Thanks for your review.
Changes for V2:
- Modified the commit message in more detail than before.
Best Regards,
Hoegeun
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index a11b795..6ee0dac 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
return ret;
dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
- if (!dsi->bridge_node)
- return -EINVAL;
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
2017-06-14 6:33 ` [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing Hoegeun Kwon
@ 2017-06-14 12:30 ` Tobias Jakobi
2017-06-20 4:51 ` Hoegeun Kwon
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Jakobi @ 2017-06-14 12:30 UTC (permalink / raw)
To: Hoegeun Kwon, inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk
Cc: javier, a.hajda, dri-devel, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Hello Hoegeun,
my last question (does this regress the case "node required, but
absent") still stands.
Hoegeun Kwon wrote:
> Remove the error handling of bridge_node because the bridge_node is
> required optionally.
I don't think a construction like that exists. Either it's required, or
it's optional. "required optionally" makes no sense to me (but I'm not a
native speaker).
- Tobias
> For example, In case of Exynos SoC, a bridge device such as mDNIe and
> MIC could be placed between Display Controller and MIPI DSI device but
> the bridge device is required optionally.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
>
> Hi Inki and Tobias,
>
> Thanks for your review.
>
> Changes for V2:
> - Modified the commit message in more detail than before.
>
> Best Regards,
> Hoegeun
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index a11b795..6ee0dac 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
> return ret;
>
> dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
> - if (!dsi->bridge_node)
> - return -EINVAL;
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing
2017-06-14 12:30 ` Tobias Jakobi
@ 2017-06-20 4:51 ` Hoegeun Kwon
0 siblings, 0 replies; 3+ messages in thread
From: Hoegeun Kwon @ 2017-06-20 4:51 UTC (permalink / raw)
To: Tobias Jakobi, inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk
Cc: javier, a.hajda, dri-devel, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Hoegeun Kwon
Hello Tobias,
Sorry for late reply.
On 06/14/2017 09:30 PM, Tobias Jakobi wrote:
> Hello Hoegeun,
>
> my last question (does this regress the case "node required, but
> absent") still stands.
>
>
> Hoegeun Kwon wrote:
>> Remove the error handling of bridge_node because the bridge_node is
>> required optionally.
> I don't think a construction like that exists. Either it's required, or
> it's optional. "required optionally" makes no sense to me (but I'm not a
> native speaker).
>
> - Tobias
The bridge_node is optional.
I will change commit message and send ver3 patch.
Best regards,
Hoegeun
>
>
>> For example, In case of Exynos SoC, a bridge device such as mDNIe and
>> MIC could be placed between Display Controller and MIPI DSI device but
>> the bridge device is required optionally.
>>
>> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
>> ---
>>
>> Hi Inki and Tobias,
>>
>> Thanks for your review.
>>
>> Changes for V2:
>> - Modified the commit message in more detail than before.
>>
>> Best Regards,
>> Hoegeun
>>
>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> index a11b795..6ee0dac 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
>> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi)
>> return ret;
>>
>> dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0);
>> - if (!dsi->bridge_node)
>> - return -EINVAL;
>>
>> return 0;
>> }
>>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-20 4:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170614063359epcas5p46658bba447468cd367d0684bd9485bf8@epcas5p4.samsung.com>
2017-06-14 6:33 ` [PATCH v2] drm/exynos/dsi: Remove error handling for bridge_node DT parsing Hoegeun Kwon
2017-06-14 12:30 ` Tobias Jakobi
2017-06-20 4:51 ` Hoegeun Kwon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).