* [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
@ 2018-03-15 13:43 Giulio Benetti
2018-03-16 6:47 ` Maxime Ripard
0 siblings, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2018-03-15 13:43 UTC (permalink / raw)
To: Maxime Ripard
Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel, Giulio Benetti
The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
for the needed pins.
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index bd0cd32..d4b2d18 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -922,6 +922,14 @@
pins = "PI20", "PI21";
function = "uart7";
};
+
+ lcd0_rgb888_pins: lcd0-rgb888-pins {
+ pins = "PD0", "PD1", "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
+ "PD8", "PD9", "PD10", "PD11", "PD12", "PD13", "PD14", "PD15",
+ "PD16", "PD17", "PD18", "PD19", "PD20", "PD21", "PD22", "PD23",
+ "PD24", "PD25", "PD26", "PD27";
+ function = "lcd0";
+ };
};
timer@1c20c00 {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
2018-03-15 13:43 [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output Giulio Benetti
@ 2018-03-16 6:47 ` Maxime Ripard
2018-03-16 9:19 ` Giulio Benetti
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2018-03-16 6:47 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
Hi Giulio,
On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote:
> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
> for the needed pins.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Like we discussed last time, we only merge this kind of patches if
there's an immediate user.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
2018-03-16 6:47 ` Maxime Ripard
@ 2018-03-16 9:19 ` Giulio Benetti
2018-03-16 9:39 ` Chen-Yu Tsai
0 siblings, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2018-03-16 9:19 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Chen-Yu Tsai, devicetree, linux-arm-kernel, linux-kernel
Hi Maxime,
Il 16/03/2018 07:47, Maxime Ripard ha scritto:
> Hi Giulio,
>
> On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote:
>> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
>> for the needed pins.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>
> Like we discussed last time, we only merge this kind of patches if
> there's an immediate user.
You're right.
In few time(I hope), I'm going to send dts for Linova1-4_3 and Linova1-7,
where I use those pins.
I have also to send 2 patches for 2 new panels for panel-simple.
So I think I have to send 2 displays' patches before.
And a patchset for the 2 boards and rgb888 pins.
One question: do I have to wait for panels' patches to applied and then
send patchset for boards dts?
Or can I send a unique patchset?
Because as I understand those patches should be applied to 2 different
repositories, right?
Thanks in advance
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
>
> Maxime
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
2018-03-16 9:19 ` Giulio Benetti
@ 2018-03-16 9:39 ` Chen-Yu Tsai
2018-03-16 13:11 ` Giulio Benetti
0 siblings, 1 reply; 5+ messages in thread
From: Chen-Yu Tsai @ 2018-03-16 9:39 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Maxime Ripard, devicetree, linux-arm-kernel, linux-kernel
On Fri, Mar 16, 2018 at 5:19 PM, Giulio Benetti
<giulio.benetti@micronovasrl.com> wrote:
> Hi Maxime,
>
> Il 16/03/2018 07:47, Maxime Ripard ha scritto:
>>
>> Hi Giulio,
>>
>> On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote:
>>>
>>> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
>>> for the needed pins.
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>
>>
>> Like we discussed last time, we only merge this kind of patches if
>> there's an immediate user.
>
>
> You're right.
> In few time(I hope), I'm going to send dts for Linova1-4_3 and Linova1-7,
> where I use those pins.
> I have also to send 2 patches for 2 new panels for panel-simple.
>
> So I think I have to send 2 displays' patches before.
> And a patchset for the 2 boards and rgb888 pins.
>
> One question: do I have to wait for panels' patches to applied and then send
> patchset for boards dts?
> Or can I send a unique patchset?
> Because as I understand those patches should be applied to 2 different
> repositories, right?
If none of them have been merged yet, it's best to send all of them
as part of the same series, and to all parties involved. That way,
people have the full picture of what you're trying to achieve when
they review your patches. Unless your series is really big.
Maintainers will pick up patches that need to go through their trees.
In general you don't need to do much coordination beyond pointing out
whether the patches are safe to go in independently or there are
dependencies that the maintainers need to be aware of.
ChenYu
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
2018-03-16 9:39 ` Chen-Yu Tsai
@ 2018-03-16 13:11 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2018-03-16 13:11 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Maxime Ripard, devicetree, linux-arm-kernel, linux-kernel
Hi,
Il 16/03/2018 10:39, Chen-Yu Tsai ha scritto:
> On Fri, Mar 16, 2018 at 5:19 PM, Giulio Benetti
> <giulio.benetti@micronovasrl.com> wrote:
>> Hi Maxime,
>>
>> Il 16/03/2018 07:47, Maxime Ripard ha scritto:
>>>
>>> Hi Giulio,
>>>
>>> On Thu, Mar 15, 2018 at 02:43:30PM +0100, Giulio Benetti wrote:
>>>>
>>>> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
>>>> for the needed pins.
>>>>
>>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>>
>>>
>>> Like we discussed last time, we only merge this kind of patches if
>>> there's an immediate user.
>>
>>
>> You're right.
>> In few time(I hope), I'm going to send dts for Linova1-4_3 and Linova1-7,
>> where I use those pins.
>> I have also to send 2 patches for 2 new panels for panel-simple.
>>
>> So I think I have to send 2 displays' patches before.
>> And a patchset for the 2 boards and rgb888 pins.
>>
>> One question: do I have to wait for panels' patches to applied and then send
>> patchset for boards dts?
>> Or can I send a unique patchset?
>> Because as I understand those patches should be applied to 2 different
>> repositories, right?
>
> If none of them have been merged yet, it's best to send all of them
> as part of the same series, and to all parties involved. That way,
> people have the full picture of what you're trying to achieve when
> they review your patches. Unless your series is really big.
>
> Maintainers will pick up patches that need to go through their trees.
> In general you don't need to do much coordination beyond pointing out
> whether the patches are safe to go in independently or there are
> dependencies that the maintainers need to be aware of.
Ok, now it's clear to me.
I've submitted only few patches till now,
so I didn't know about that.
Thank you very much
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
>
> ChenYu
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-16 13:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 13:43 [PATCH] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output Giulio Benetti
2018-03-16 6:47 ` Maxime Ripard
2018-03-16 9:19 ` Giulio Benetti
2018-03-16 9:39 ` Chen-Yu Tsai
2018-03-16 13:11 ` Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).