linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] media: pci: ttpci: av7110: Fix possible buffer overflow in debiirq()
@ 2020-05-30 15:27 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-30 15:27 UTC (permalink / raw)
  To: Jia-Ju Bai, linux-media; +Cc: linux-kernel, Mauro Carvalho Chehab, Sean Young

> To fix this possible bug, data[0] is assigned to a local variable, which
> replaces the use of data[0].

How do you think about a wording variant like the following?

  Thus assign the first element of the data array to a local variable
  so that it can be used as an array index together with the data structure
  member “ci_slot” in a safer way.


Would you like to add the tag “Fixes” to the commit message?
Are you going to take this possibility into account for any more patches?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-05-30 15:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30 15:27 [PATCH] media: pci: ttpci: av7110: Fix possible buffer overflow in debiirq() Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).