From: "Christian König" <christian.koenig@amd.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>,
Alex Deucher <alexander.deucher@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware
Date: Mon, 13 Sep 2021 10:39:34 +0200 [thread overview]
Message-ID: <e9e4e529-b3af-2862-eb38-8e5415108ba4@amd.com> (raw)
In-Reply-To: <20210913083411.11215-1-pmenzel@molgen.mpg.de>
Am 13.09.21 um 10:34 schrieb Paul Menzel:
> The warning
>
> amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
>
> leaves the reader wondering, if anything can be done about it. As it’s
> unsupported in the hardware, and nothing can be done about, mention that
> in the log message.
>
> amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware
I think we should just completely remove the message instead.
Christian.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c7797eac83c3..c4c56c57b0c0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
> default:
> adev->gmc.tmz_enabled = false;
> dev_warn(adev->dev,
> - "Trusted Memory Zone (TMZ) feature not supported\n");
> + "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
> break;
> }
> }
prev parent reply other threads:[~2021-09-13 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 8:34 [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Paul Menzel
2021-09-13 8:34 ` [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info Paul Menzel
2021-09-13 16:53 ` Alex Deucher
2021-09-13 8:39 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9e4e529-b3af-2862-eb38-8e5415108ba4@amd.com \
--to=christian.koenig@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).