* [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware
@ 2021-09-13 8:34 Paul Menzel
2021-09-13 8:34 ` [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info Paul Menzel
2021-09-13 8:39 ` [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Christian König
0 siblings, 2 replies; 4+ messages in thread
From: Paul Menzel @ 2021-09-13 8:34 UTC (permalink / raw)
To: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter
Cc: Paul Menzel, amd-gfx, dri-devel, linux-kernel
The warning
amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
leaves the reader wondering, if anything can be done about it. As it’s
unsupported in the hardware, and nothing can be done about, mention that
in the log message.
amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index c7797eac83c3..c4c56c57b0c0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
default:
adev->gmc.tmz_enabled = false;
dev_warn(adev->dev,
- "Trusted Memory Zone (TMZ) feature not supported\n");
+ "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
break;
}
}
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info
2021-09-13 8:34 [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Paul Menzel
@ 2021-09-13 8:34 ` Paul Menzel
2021-09-13 16:53 ` Alex Deucher
2021-09-13 8:39 ` [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Christian König
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2021-09-13 8:34 UTC (permalink / raw)
To: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter
Cc: Paul Menzel, amd-gfx, dri-devel, linux-kernel
As the user cannot do anything about the unsupported Trusted Memory Zone
(TMZ) feature, do not warn about it, but make it informational, so
demote the log level from warning to info.
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
index c4c56c57b0c0..bfa0275ff5d4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
@@ -598,7 +598,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
break;
default:
adev->gmc.tmz_enabled = false;
- dev_warn(adev->dev,
+ dev_info(adev->dev,
"Trusted Memory Zone (TMZ) feature not supported by hardware\n");
break;
}
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware
2021-09-13 8:34 [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Paul Menzel
2021-09-13 8:34 ` [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info Paul Menzel
@ 2021-09-13 8:39 ` Christian König
1 sibling, 0 replies; 4+ messages in thread
From: Christian König @ 2021-09-13 8:39 UTC (permalink / raw)
To: Paul Menzel, Alex Deucher, Pan, Xinhui, David Airlie, Daniel Vetter
Cc: amd-gfx, dri-devel, linux-kernel
Am 13.09.21 um 10:34 schrieb Paul Menzel:
> The warning
>
> amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported
>
> leaves the reader wondering, if anything can be done about it. As it’s
> unsupported in the hardware, and nothing can be done about, mention that
> in the log message.
>
> amdgpu 0000:05:00.0: amdgpu: Trusted Memory Zone (TMZ) feature not supported by hardware
I think we should just completely remove the message instead.
Christian.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c7797eac83c3..c4c56c57b0c0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -599,7 +599,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
> default:
> adev->gmc.tmz_enabled = false;
> dev_warn(adev->dev,
> - "Trusted Memory Zone (TMZ) feature not supported\n");
> + "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
> break;
> }
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info
2021-09-13 8:34 ` [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info Paul Menzel
@ 2021-09-13 16:53 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2021-09-13 16:53 UTC (permalink / raw)
To: Paul Menzel
Cc: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, amd-gfx list, Maling list - DRI developers, LKML
Applied. Thanks.
Alex
On Mon, Sep 13, 2021 at 4:46 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> As the user cannot do anything about the unsupported Trusted Memory Zone
> (TMZ) feature, do not warn about it, but make it informational, so
> demote the log level from warning to info.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> index c4c56c57b0c0..bfa0275ff5d4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> @@ -598,7 +598,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
> break;
> default:
> adev->gmc.tmz_enabled = false;
> - dev_warn(adev->dev,
> + dev_info(adev->dev,
> "Trusted Memory Zone (TMZ) feature not supported by hardware\n");
> break;
> }
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-13 16:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 8:34 [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Paul Menzel
2021-09-13 8:34 ` [PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info Paul Menzel
2021-09-13 16:53 ` Alex Deucher
2021-09-13 8:39 ` [PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).