* [PATCH] torture: remove exporting of internal functions
@ 2019-07-04 12:57 Denis Efremov
2019-07-04 14:19 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Denis Efremov @ 2019-07-04 12:57 UTC (permalink / raw)
To: Paul E. McKenney
Cc: Denis Efremov, Davidlohr Bueso, Josh Triplett, linux-kernel
The functions torture_onoff_cleanup, torture_shuffle_cleanup are declared
as static and marked as EXPORT_SYMBOL. It's a bit confusing for an
internal function to be exported. The area of visibility for such function
is its .c file and all other modules. Other *.c files of the same module
can't use it, despite all other modules can. Relying on the fact that these
are the internal functions and they are not a crucial part of the API, the
patch removes the EXPORT_SYMBOL marking of the torture_onoff_cleanup and
torture_shuffle_cleanup. The patch complements commit cc47ae083026
("rcutorture: Abstract torture-test cleanup").
Signed-off-by: Denis Efremov <efremov@linux.com>
---
kernel/torture.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/torture.c b/kernel/torture.c
index 17b2be9bde12..fbbcc4abe426 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -263,7 +263,6 @@ static void torture_onoff_cleanup(void)
onoff_task = NULL;
#endif /* #ifdef CONFIG_HOTPLUG_CPU */
}
-EXPORT_SYMBOL_GPL(torture_onoff_cleanup);
/*
* Print online/offline testing statistics.
@@ -449,7 +448,6 @@ static void torture_shuffle_cleanup(void)
}
shuffler_task = NULL;
}
-EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);
/*
* Variables for auto-shutdown. This allows "lights out" torture runs
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] torture: remove exporting of internal functions
2019-07-04 12:57 [PATCH] torture: remove exporting of internal functions Denis Efremov
@ 2019-07-04 14:19 ` Paul E. McKenney
2019-07-04 14:46 ` Denis Efremov
0 siblings, 1 reply; 3+ messages in thread
From: Paul E. McKenney @ 2019-07-04 14:19 UTC (permalink / raw)
To: Denis Efremov; +Cc: Davidlohr Bueso, Josh Triplett, linux-kernel
On Thu, Jul 04, 2019 at 03:57:19PM +0300, Denis Efremov wrote:
> The functions torture_onoff_cleanup, torture_shuffle_cleanup are declared
> as static and marked as EXPORT_SYMBOL. It's a bit confusing for an
> internal function to be exported. The area of visibility for such function
> is its .c file and all other modules. Other *.c files of the same module
> can't use it, despite all other modules can. Relying on the fact that these
> are the internal functions and they are not a crucial part of the API, the
> patch removes the EXPORT_SYMBOL marking of the torture_onoff_cleanup and
> torture_shuffle_cleanup. The patch complements commit cc47ae083026
> ("rcutorture: Abstract torture-test cleanup").
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Good catch, applied, thank you!
I reworked the commit message as follows, so could you please check
to make sure that I didn't fold, spindle, or otherwise mutilate
something?
Thanx, Paul
------------------------------------------------------------------------
commit 0848a1dfea913f0c384b49a1f61f84b95a4d555a
Author: Denis Efremov <efremov@linux.com>
Date: Thu Jul 4 15:57:19 2019 +0300
torture: Remove exporting of internal functions
The functions torture_onoff_cleanup() and torture_shuffle_cleanup()
are declared static and marked EXPORT_SYMBOL_GPL(), which is at best an
odd combination. Because these functions are not used outside of the
kernel/torture.c file they are defined in, this commit removes their
EXPORT_SYMBOL_GPL() marking.
Fixes: cc47ae083026 ("rcutorture: Abstract torture-test cleanup")
Signed-off-by: Denis Efremov <efremov@linux.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
diff --git a/kernel/torture.c b/kernel/torture.c
index a8d9bdfba7c3..7c13f5558b71 100644
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -263,7 +263,6 @@ static void torture_onoff_cleanup(void)
onoff_task = NULL;
#endif /* #ifdef CONFIG_HOTPLUG_CPU */
}
-EXPORT_SYMBOL_GPL(torture_onoff_cleanup);
/*
* Print online/offline testing statistics.
@@ -449,7 +448,6 @@ static void torture_shuffle_cleanup(void)
}
shuffler_task = NULL;
}
-EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);
/*
* Variables for auto-shutdown. This allows "lights out" torture runs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] torture: remove exporting of internal functions
2019-07-04 14:19 ` Paul E. McKenney
@ 2019-07-04 14:46 ` Denis Efremov
0 siblings, 0 replies; 3+ messages in thread
From: Denis Efremov @ 2019-07-04 14:46 UTC (permalink / raw)
To: paulmck; +Cc: Davidlohr Bueso, Josh Triplett, linux-kernel
> I reworked the commit message as follows, so could you please check
> to make sure that I didn't fold, spindle, or otherwise mutilate
> something?
>
> Thanx, Paul
Perfect, thanks!
Denis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-04 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 12:57 [PATCH] torture: remove exporting of internal functions Denis Efremov
2019-07-04 14:19 ` Paul E. McKenney
2019-07-04 14:46 ` Denis Efremov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).