From: Xiaoyao Li <xiaoyao.li@intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Nadav Amit <namit@cs.technion.ac.il>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] kvm: x86: Use KVM_DEBUGREG_NEED_RELOAD instead of KVM_DEBUGREG_BP_ENABLED
Date: Fri, 24 Apr 2020 21:21:57 +0800 [thread overview]
Message-ID: <ea6e0343-8c51-52c7-ba7b-48d3d4e7177a@intel.com> (raw)
In-Reply-To: <20200423192949.GO17824@linux.intel.com>
On 4/24/2020 3:29 AM, Sean Christopherson wrote:
> On Thu, Apr 16, 2020 at 06:15:08PM +0800, Xiaoyao Li wrote:
>> Once any #BP enabled in DR7, it will set KVM_DEBUGREG_BP_ENABLED, which
>> leads to reload DRn before every VM entry even if none of DRn changed.
>>
>> Drop KVM_DEBUGREG_BP_ENABLED flag and set KVM_DEBUGREG_NEED_RELOAD flag
>> for the cases that DRn need to be reloaded instead, to avoid unnecessary
>> DRn reload.
>
> Loading DRs on every VM-Enter _is_ necessary if there are breakpoints
> enabled for the guest. The hardware DR values are not "stable", e.g. they
> are loaded with the host's values immediately after saving the guest's
> value (if DR_EXITING is disabled) in vcpu_enter_guest(), notably iff the
> host has an active/enabled breakpoint.
May bad, bbviously I didn't think about it.
> My bet is that DRs can be changed
> from interrupt context as well.
So set KVM_DEBUGREG_NEED_RELOAD in vcpu_load won't help.
> Loading DRs for the guest (not necessarily the same as the guest's DRs) is
> necessary if a breakpoint is enabled so that the #DB is actually hit in
> guest. It's a similar concept to instructions that consume MSR values,
> e.g. SYSCALL, RDTSCP, etc..., even if KVM intercepts the MSR/DR, hardware
> still needs the correct value so that the guest behavior is correct.
>
>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>> ---
>> arch/x86/include/asm/kvm_host.h | 3 +--
>> arch/x86/kvm/x86.c | 4 ++--
>> 2 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
>> index f465c76e6e5a..87e2d020351e 100644
>> --- a/arch/x86/include/asm/kvm_host.h
>> +++ b/arch/x86/include/asm/kvm_host.h
>> @@ -509,9 +509,8 @@ struct kvm_pmu {
>> struct kvm_pmu_ops;
>>
>> enum {
>> - KVM_DEBUGREG_BP_ENABLED = 1,
>> + KVM_DEBUGREG_NEED_RELOAD = 1,
>> KVM_DEBUGREG_WONT_EXIT = 2,
>> - KVM_DEBUGREG_NEED_RELOAD = 4,
>> };
>>
>> struct kvm_mtrr_range {
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index cce926658d10..71264df64001 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -1086,9 +1086,8 @@ static void kvm_update_dr7(struct kvm_vcpu *vcpu)
>> else
>> dr7 = vcpu->arch.dr7;
>> kvm_x86_ops.set_dr7(vcpu, dr7);
>> - vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_BP_ENABLED;
>> if (dr7 & DR7_BP_EN_MASK)
>> - vcpu->arch.switch_db_regs |= KVM_DEBUGREG_BP_ENABLED;
>> + vcpu->arch.switch_db_regs |= KVM_DEBUGREG_NEED_RELOAD;
>> }
>>
>> static u64 kvm_dr6_fixed(struct kvm_vcpu *vcpu)
>> @@ -1128,6 +1127,7 @@ static int __kvm_set_dr(struct kvm_vcpu *vcpu, int dr, unsigned long val)
>> break;
>> }
>>
>> + vcpu->arch.switch_db_regs |= KVM_DEBUGREG_NEED_RELOAD;
>> return 0;
>> }
>>
>> --
>> 2.20.1
>>
next prev parent reply other threads:[~2020-04-24 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 10:15 [RFC PATCH 0/3] kvm: x86: Cleanup and optimazation of switch_db_regs Xiaoyao Li
2020-04-16 10:15 ` [RFC PATCH 1/3] kvm: x86: Rename KVM_DEBUGREG_RELOAD to KVM_DEBUGREG_NEED_RELOAD Xiaoyao Li
2020-04-23 19:09 ` Sean Christopherson
2020-04-24 13:28 ` Xiaoyao Li
2020-04-24 20:21 ` Peter Xu
2020-04-24 20:29 ` Sean Christopherson
2020-04-24 20:59 ` Peter Xu
2020-04-25 7:48 ` Paolo Bonzini
2020-04-27 14:37 ` Peter Xu
2020-04-27 16:06 ` Xiaoyao Li
2020-04-25 8:07 ` Paolo Bonzini
2020-04-25 16:54 ` Nadav Amit
2020-04-25 19:16 ` Paolo Bonzini
2020-04-16 10:15 ` [RFC PATCH 2/3] kvm: x86: Use KVM_DEBUGREG_NEED_RELOAD instead of KVM_DEBUGREG_BP_ENABLED Xiaoyao Li
2020-04-23 19:29 ` Sean Christopherson
2020-04-24 13:21 ` Xiaoyao Li [this message]
2020-04-16 10:15 ` [RFC PATCH 3/3] kvm: x86: skip DRn reload if previous VM exit is DR access VM exit Xiaoyao Li
2020-04-23 19:31 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea6e0343-8c51-52c7-ba7b-48d3d4e7177a@intel.com \
--to=xiaoyao.li@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@cs.technion.ac.il \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).