linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: tse850: the emac<->phy interface is rmii
@ 2021-09-20 20:37 Peter Rosin
  2021-09-21  9:14 ` Nicolas Ferre
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Rosin @ 2021-09-20 20:37 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Rob Herring, Nicolas Ferre, Alexandre Belloni, Ludovic Desroches,
	devicetree, linux-kernel

From d5ff443099cdf29a34128a6440e8debd71202aaa Mon Sep 17 00:00:00 2001
From: Peter Rosin <peda@axentia.se>

This went unnoticed until commit 7897b071ac3b ("net: macb: convert
to phylink") which tickled the problem. The sama5d3 emac has never
been capable of rgmii, and it all just happened to work before that
commit.

Fixes: 21dd0ece34c2 ("ARM: dts: at91: add devicetree for the Axentia TSE-850")
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-tse850-3.dts b/arch/arm/boot/dts/at91-tse850-3.dts
index 3ca97b47c69c..7e5c598e7e68 100644
--- a/arch/arm/boot/dts/at91-tse850-3.dts
+++ b/arch/arm/boot/dts/at91-tse850-3.dts
@@ -262,7 +262,7 @@
 &macb1 {
 	status = "okay";
 
-	phy-mode = "rgmii";
+	phy-mode = "rmii";
 
 	#address-cells = <1>;
 	#size-cells = <0>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: at91: tse850: the emac<->phy interface is rmii
  2021-09-20 20:37 [PATCH] ARM: dts: at91: tse850: the emac<->phy interface is rmii Peter Rosin
@ 2021-09-21  9:14 ` Nicolas Ferre
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2021-09-21  9:14 UTC (permalink / raw)
  To: Peter Rosin, linux-arm-kernel
  Cc: Rob Herring, Alexandre Belloni, Ludovic Desroches, devicetree,
	linux-kernel

On 20/09/2021 at 22:37, Peter Rosin wrote:
>>From d5ff443099cdf29a34128a6440e8debd71202aaa Mon Sep 17 00:00:00 2001
> From: Peter Rosin <peda@axentia.se>
> 
> This went unnoticed until commit 7897b071ac3b ("net: macb: convert
> to phylink") which tickled the problem. The sama5d3 emac has never
> been capable of rgmii, and it all just happened to work before that
> commit.
> 
> Fixes: 21dd0ece34c2 ("ARM: dts: at91: add devicetree for the Axentia TSE-850")
> Signed-off-by: Peter Rosin <peda@axentia.se>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
and queued to at91-dt for 5.16.

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-tse850-3.dts b/arch/arm/boot/dts/at91-tse850-3.dts
> index 3ca97b47c69c..7e5c598e7e68 100644
> --- a/arch/arm/boot/dts/at91-tse850-3.dts
> +++ b/arch/arm/boot/dts/at91-tse850-3.dts
> @@ -262,7 +262,7 @@
>   &macb1 {
>          status = "okay";
> 
> -       phy-mode = "rgmii";
> +       phy-mode = "rmii";
> 
>          #address-cells = <1>;
>          #size-cells = <0>;
> --
> 2.20.1
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-21  9:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-20 20:37 [PATCH] ARM: dts: at91: tse850: the emac<->phy interface is rmii Peter Rosin
2021-09-21  9:14 ` Nicolas Ferre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).