* [PATCH] mm/shuffle: fix section mismatch warning
@ 2021-05-14 13:59 Arnd Bergmann
2021-05-14 14:02 ` David Hildenbrand
2021-05-14 17:48 ` Nathan Chancellor
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-05-14 13:59 UTC (permalink / raw)
To: Andrew Morton, Nathan Chancellor, Nick Desaulniers
Cc: Arnd Bergmann, David Hildenbrand, Wei Yang, Dan Williams,
linux-mm, linux-kernel, clang-built-linux
From: Arnd Bergmann <arnd@arndb.de>
clang sometimes decides not to inline shuffle_zone(), but it calls
a __meminit function. Without the extra __meminit annotation we get
this warning:
WARNING: modpost: vmlinux.o(.text+0x2a86d4): Section mismatch in reference from the function shuffle_zone() to the function .meminit.text:__shuffle_zone()
The function shuffle_zone() references
the function __meminit __shuffle_zone().
This is often because shuffle_zone lacks a __meminit
annotation or the annotation of __shuffle_zone is wrong.
shuffle_free_memory() did not show the same problem in my tests, but
it could happen in theory as well, so mark both as __meminit.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
mm/shuffle.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/shuffle.h b/mm/shuffle.h
index 71b784f0b7c3..cec62984f7d3 100644
--- a/mm/shuffle.h
+++ b/mm/shuffle.h
@@ -10,7 +10,7 @@
DECLARE_STATIC_KEY_FALSE(page_alloc_shuffle_key);
extern void __shuffle_free_memory(pg_data_t *pgdat);
extern bool shuffle_pick_tail(void);
-static inline void shuffle_free_memory(pg_data_t *pgdat)
+static inline void __meminit shuffle_free_memory(pg_data_t *pgdat)
{
if (!static_branch_unlikely(&page_alloc_shuffle_key))
return;
@@ -18,7 +18,7 @@ static inline void shuffle_free_memory(pg_data_t *pgdat)
}
extern void __shuffle_zone(struct zone *z);
-static inline void shuffle_zone(struct zone *z)
+static inline void __meminit shuffle_zone(struct zone *z)
{
if (!static_branch_unlikely(&page_alloc_shuffle_key))
return;
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/shuffle: fix section mismatch warning
2021-05-14 13:59 [PATCH] mm/shuffle: fix section mismatch warning Arnd Bergmann
@ 2021-05-14 14:02 ` David Hildenbrand
2021-05-14 17:48 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2021-05-14 14:02 UTC (permalink / raw)
To: Arnd Bergmann, Andrew Morton, Nathan Chancellor, Nick Desaulniers
Cc: Arnd Bergmann, Wei Yang, Dan Williams, linux-mm, linux-kernel,
clang-built-linux
On 14.05.21 15:59, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> clang sometimes decides not to inline shuffle_zone(), but it calls
> a __meminit function. Without the extra __meminit annotation we get
> this warning:
>
> WARNING: modpost: vmlinux.o(.text+0x2a86d4): Section mismatch in reference from the function shuffle_zone() to the function .meminit.text:__shuffle_zone()
> The function shuffle_zone() references
> the function __meminit __shuffle_zone().
> This is often because shuffle_zone lacks a __meminit
> annotation or the annotation of __shuffle_zone is wrong.
>
> shuffle_free_memory() did not show the same problem in my tests, but
> it could happen in theory as well, so mark both as __meminit.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> mm/shuffle.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/shuffle.h b/mm/shuffle.h
> index 71b784f0b7c3..cec62984f7d3 100644
> --- a/mm/shuffle.h
> +++ b/mm/shuffle.h
> @@ -10,7 +10,7 @@
> DECLARE_STATIC_KEY_FALSE(page_alloc_shuffle_key);
> extern void __shuffle_free_memory(pg_data_t *pgdat);
> extern bool shuffle_pick_tail(void);
> -static inline void shuffle_free_memory(pg_data_t *pgdat)
> +static inline void __meminit shuffle_free_memory(pg_data_t *pgdat)
> {
> if (!static_branch_unlikely(&page_alloc_shuffle_key))
> return;
> @@ -18,7 +18,7 @@ static inline void shuffle_free_memory(pg_data_t *pgdat)
> }
>
> extern void __shuffle_zone(struct zone *z);
> -static inline void shuffle_zone(struct zone *z)
> +static inline void __meminit shuffle_zone(struct zone *z)
> {
> if (!static_branch_unlikely(&page_alloc_shuffle_key))
> return;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/shuffle: fix section mismatch warning
2021-05-14 13:59 [PATCH] mm/shuffle: fix section mismatch warning Arnd Bergmann
2021-05-14 14:02 ` David Hildenbrand
@ 2021-05-14 17:48 ` Nathan Chancellor
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2021-05-14 17:48 UTC (permalink / raw)
To: Arnd Bergmann, Andrew Morton, Nick Desaulniers
Cc: Arnd Bergmann, David Hildenbrand, Wei Yang, Dan Williams,
linux-mm, linux-kernel, clang-built-linux
On 5/14/2021 6:59 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> clang sometimes decides not to inline shuffle_zone(), but it calls
> a __meminit function. Without the extra __meminit annotation we get
> this warning:
>
> WARNING: modpost: vmlinux.o(.text+0x2a86d4): Section mismatch in reference from the function shuffle_zone() to the function .meminit.text:__shuffle_zone()
> The function shuffle_zone() references
> the function __meminit __shuffle_zone().
> This is often because shuffle_zone lacks a __meminit
> annotation or the annotation of __shuffle_zone is wrong.
>
> shuffle_free_memory() did not show the same problem in my tests, but
> it could happen in theory as well, so mark both as __meminit.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> mm/shuffle.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/shuffle.h b/mm/shuffle.h
> index 71b784f0b7c3..cec62984f7d3 100644
> --- a/mm/shuffle.h
> +++ b/mm/shuffle.h
> @@ -10,7 +10,7 @@
> DECLARE_STATIC_KEY_FALSE(page_alloc_shuffle_key);
> extern void __shuffle_free_memory(pg_data_t *pgdat);
> extern bool shuffle_pick_tail(void);
> -static inline void shuffle_free_memory(pg_data_t *pgdat)
> +static inline void __meminit shuffle_free_memory(pg_data_t *pgdat)
> {
> if (!static_branch_unlikely(&page_alloc_shuffle_key))
> return;
> @@ -18,7 +18,7 @@ static inline void shuffle_free_memory(pg_data_t *pgdat)
> }
>
> extern void __shuffle_zone(struct zone *z);
> -static inline void shuffle_zone(struct zone *z)
> +static inline void __meminit shuffle_zone(struct zone *z)
> {
> if (!static_branch_unlikely(&page_alloc_shuffle_key))
> return;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-14 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 13:59 [PATCH] mm/shuffle: fix section mismatch warning Arnd Bergmann
2021-05-14 14:02 ` David Hildenbrand
2021-05-14 17:48 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).