From: Michal Simek <michal.simek@xilinx.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
jassisinghbrar@gmail.com, michal.simek@xilinx.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto
Date: Wed, 31 Jul 2019 10:31:49 +0200 [thread overview]
Message-ID: <eaf1fcbe-615e-0fec-d330-ae94e8f3c102@xilinx.com> (raw)
In-Reply-To: <20190709172841.13769-1-nishkadg.linux@gmail.com>
On 09. 07. 19 19:28, Nishka Dasgupta wrote:
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a goto from the middle of the loop, there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> goto.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 86887c9a349a..bd80d4c10ec2 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -661,6 +661,7 @@ static int zynqmp_ipi_probe(struct platform_device *pdev)
> if (ret) {
> dev_err(dev, "failed to probe subdev.\n");
> ret = -EINVAL;
> + of_node_put(nc);
> goto free_mbox_dev;
> }
> mbox++;
>
Patch is good but when you are saying that this was found by Coccinelle
then it should be added as script to kernel to detect it.
Thanks,
Michal
next prev parent reply other threads:[~2019-07-31 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:28 [PATCH] mailbox: zynqmp-ipi-mailbox: Add of_node_put() before goto Nishka Dasgupta
2019-07-31 8:31 ` Michal Simek [this message]
2019-07-31 13:06 ` Nishka Dasgupta
2019-07-31 14:21 ` Michal Simek
2019-08-02 4:59 ` Nishka Dasgupta
2019-08-02 5:12 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaf1fcbe-615e-0fec-d330-ae94e8f3c102@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).