* [PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions
@ 2018-01-29 21:26 SF Markus Elfring
2018-02-04 11:01 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2018-01-29 21:26 UTC (permalink / raw)
To: linux-iio, linux-input, Hartmut Knaack, Jiri Kosina,
Jonathan Cameron, Lars-Peter Clausen, Peter Meerwald-Stadler,
Srinivas Pandruvada
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 29 Jan 2018 22:20:07 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +---
drivers/iio/orientation/hid-sensor-rotation.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c b/drivers/iio/orientation/hid-sensor-incl-3d.c
index 1e5451d1ff88..742c0e0eb4cf 100644
--- a/drivers/iio/orientation/hid-sensor-incl-3d.c
+++ b/drivers/iio/orientation/hid-sensor-incl-3d.c
@@ -336,10 +336,8 @@ static int hid_incl_3d_probe(struct platform_device *pdev)
indio_dev->channels = kmemdup(incl_3d_channels,
sizeof(incl_3d_channels), GFP_KERNEL);
- if (!indio_dev->channels) {
- dev_err(&pdev->dev, "failed to duplicate channels\n");
+ if (!indio_dev->channels)
return -ENOMEM;
- }
ret = incl_3d_parse_report(pdev, hsdev,
(struct iio_chan_spec *)indio_dev->channels,
diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
index a69db2002414..cbf5e406b1ee 100644
--- a/drivers/iio/orientation/hid-sensor-rotation.c
+++ b/drivers/iio/orientation/hid-sensor-rotation.c
@@ -277,10 +277,8 @@ static int hid_dev_rot_probe(struct platform_device *pdev)
indio_dev->channels = devm_kmemdup(&pdev->dev, dev_rot_channels,
sizeof(dev_rot_channels),
GFP_KERNEL);
- if (!indio_dev->channels) {
- dev_err(&pdev->dev, "failed to duplicate channels\n");
+ if (!indio_dev->channels)
return -ENOMEM;
- }
ret = dev_rot_parse_report(pdev, hsdev,
(struct iio_chan_spec *)indio_dev->channels,
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions
2018-01-29 21:26 [PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
@ 2018-02-04 11:01 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2018-02-04 11:01 UTC (permalink / raw)
To: SF Markus Elfring
Cc: linux-iio, linux-input, Hartmut Knaack, Jiri Kosina,
Lars-Peter Clausen, Peter Meerwald-Stadler, Srinivas Pandruvada,
LKML, kernel-janitors
On Mon, 29 Jan 2018 22:26:15 +0100
SF Markus Elfring <elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 29 Jan 2018 22:20:07 +0100
>
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Same response as previous patch - it might not be adding much information,
but it is adding some so we should keep it.
Jonathan
> ---
> drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +---
> drivers/iio/orientation/hid-sensor-rotation.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/iio/orientation/hid-sensor-incl-3d.c b/drivers/iio/orientation/hid-sensor-incl-3d.c
> index 1e5451d1ff88..742c0e0eb4cf 100644
> --- a/drivers/iio/orientation/hid-sensor-incl-3d.c
> +++ b/drivers/iio/orientation/hid-sensor-incl-3d.c
> @@ -336,10 +336,8 @@ static int hid_incl_3d_probe(struct platform_device *pdev)
>
> indio_dev->channels = kmemdup(incl_3d_channels,
> sizeof(incl_3d_channels), GFP_KERNEL);
> - if (!indio_dev->channels) {
> - dev_err(&pdev->dev, "failed to duplicate channels\n");
> + if (!indio_dev->channels)
> return -ENOMEM;
> - }
>
> ret = incl_3d_parse_report(pdev, hsdev,
> (struct iio_chan_spec *)indio_dev->channels,
> diff --git a/drivers/iio/orientation/hid-sensor-rotation.c b/drivers/iio/orientation/hid-sensor-rotation.c
> index a69db2002414..cbf5e406b1ee 100644
> --- a/drivers/iio/orientation/hid-sensor-rotation.c
> +++ b/drivers/iio/orientation/hid-sensor-rotation.c
> @@ -277,10 +277,8 @@ static int hid_dev_rot_probe(struct platform_device *pdev)
> indio_dev->channels = devm_kmemdup(&pdev->dev, dev_rot_channels,
> sizeof(dev_rot_channels),
> GFP_KERNEL);
> - if (!indio_dev->channels) {
> - dev_err(&pdev->dev, "failed to duplicate channels\n");
> + if (!indio_dev->channels)
> return -ENOMEM;
> - }
>
> ret = dev_rot_parse_report(pdev, hsdev,
> (struct iio_chan_spec *)indio_dev->channels,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-04 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-29 21:26 [PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2018-02-04 11:01 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).