linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Andrzej Hajda <a.hajda@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 3/3] drivers: use probe_err function in obvious cases
Date: Tue, 16 Oct 2018 11:52:05 +0200	[thread overview]
Message-ID: <ec49aeb4-3f62-951c-1525-78051cd76bb0@redhat.com> (raw)
In-Reply-To: <20181016072244.1216-4-a.hajda@samsung.com>

Hello Andrzej,

On 10/16/2018 09:22 AM, Andrzej Hajda wrote:
> The patch replaces obviously matching code with probe_err function.
> There are many more places where probe_err could be used.
> The patch shows how the new function should be used, and how it
> improves the code.
> 
> It was generated by cocci script (little bit dirty):
>

This is great! I guess the easier would be to split these by kernel releases,
maybe patch #1 and #2 can land in one kernel release and then each subsystem
can merge the changes for their drivers with the dependency already in place.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat

  reply	other threads:[~2018-10-16  9:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181016072248eucas1p18943ce87e084797cd597afd4edb65a65@eucas1p1.samsung.com>
2018-10-16  7:22 ` [PATCH 0/3] driver core: add probe error check helper Andrzej Hajda
     [not found]   ` <CGME20181016072249eucas1p2303b8c06a9f7c839a971fe065b0c752e@eucas1p2.samsung.com>
2018-10-16  7:22     ` [PATCH 1/3] driver core: add probe_err log helper Andrzej Hajda
2018-10-16  9:32       ` Javier Martinez Canillas
2018-10-16 10:27       ` Mark Brown
2018-10-16 11:09         ` Greg Kroah-Hartman
2018-10-16 11:01       ` Andy Shevchenko
2018-10-16 11:29         ` Andrzej Hajda
     [not found]         ` <605bd00e-ed0d-4259-bdc3-1784b2b3b16a@samsung.com>
2018-10-16 12:55           ` Andrzej Hajda
2018-10-16 13:55             ` Andy Shevchenko
     [not found]               ` <CGME20181017085832eucas1p23dbb86230149a13634b8a091c3b1301f@eucas1p2.samsung.com>
2018-10-17  8:58                 ` [PATCH v2 " Andrzej Hajda
2018-10-17  9:56                   ` Mark Brown
2018-10-17 11:30                   ` Andy Shevchenko
2018-10-17 11:49                   ` Greg Kroah-Hartman
2018-10-17 11:29               ` [PATCH " Russell King - ARM Linux
2018-10-17 11:33                 ` Andy Shevchenko
     [not found]                   ` <CGME20181017132209eucas1p1d23615adc15663caaffb3c117dc61151@eucas1p1.samsung.com>
2018-10-17 13:22                     ` [PATCH v3 1/4] " Andrzej Hajda
2018-10-18  1:45                 ` [PATCH 1/3] " Joe Perches
     [not found]   ` <CGME20181016072249eucas1p28855602564eb74a771fe521712962680@eucas1p2.samsung.com>
2018-10-16  7:22     ` [PATCH 2/3] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2018-10-16  9:25       ` Mark Brown
2018-10-16  9:47       ` Javier Martinez Canillas
2018-10-16 13:42       ` Andy Shevchenko
     [not found]         ` <CGME20181017085952eucas1p2ff93b96d300aab2dc70b97bf266978ab@eucas1p2.samsung.com>
2018-10-17  8:59           ` [PATCH v2 " Andrzej Hajda
2018-10-17 11:35             ` Andy Shevchenko
     [not found]               ` <CGME20181017132404eucas1p2a413f6853af8f11a874650b6289d56cf@eucas1p2.samsung.com>
2018-10-17 13:24                 ` [PATCH v3 2/4] " Andrzej Hajda
2018-10-17 14:17                   ` Andy Shevchenko
     [not found]                     ` <CGME20181018064916eucas1p22f03a19eb09cecdb0061dc5a4bf99ce6@eucas1p2.samsung.com>
2018-10-18  6:49                       ` [PATCH v4 2/3] " Andrzej Hajda
     [not found]   ` <CGME20181016072250eucas1p1a763670c8509d20a6e6847eadb246817@eucas1p1.samsung.com>
2018-10-16  7:22     ` [PATCH 3/3] drivers: use probe_err function in obvious cases Andrzej Hajda
2018-10-16  9:52       ` Javier Martinez Canillas [this message]
2018-10-16 13:51       ` Andy Shevchenko
2018-10-17  9:10         ` Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec49aeb4-3f62-951c-1525-78051cd76bb0@redhat.com \
    --to=javierm@redhat.com \
    --cc=a.hajda@samsung.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).