linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] <linux/kernel.h>: drop the gcc-3.3 'const' hack in roundup()
@ 2019-02-21  3:33 Randy Dunlap
  0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2019-02-21  3:33 UTC (permalink / raw)
  To: LKML, Andrew Morton; +Cc: Matthew Wilcox

From: Randy Dunlap <rdunlap@infradead.org>

The single quotation marks around "const" were causing a
documentation markup warning with reST.  Instead of fixing that
warning, just delete that comment line and the gcc-3.3 hack of
using "const" in the roundup() macro since gcc-3.3 is no longer
supported for kernel builds.

I did around 20 different $arch builds with no problems, but
we'll just have to see if this causes problems for anyone else
out there.

Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 include/linux/kernel.h |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- lnx-50-rc7.orig/include/linux/kernel.h
+++ lnx-50-rc7/include/linux/kernel.h
@@ -133,12 +133,10 @@
  *
  * Rounds @x up to next multiple of @y. If @y will always be a power
  * of 2, consider using the faster round_up().
- *
- * The `const' here prevents gcc-3.3 from calling __divdi3
  */
 #define roundup(x, y) (					\
 {							\
-	const typeof(y) __y = y;			\
+	typeof(y) __y = y;				\
 	(((x) + (__y - 1)) / __y) * __y;		\
 }							\
 )



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-02-21  3:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21  3:33 [PATCH] <linux/kernel.h>: drop the gcc-3.3 'const' hack in roundup() Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).