* [PATCH v3] cpuidle: big.LITTLE: add of_node_put()
@ 2018-11-20 16:14 Yangtao Li
2018-12-09 6:20 ` Frank Lee
2018-12-10 11:59 ` Daniel Lezcano
0 siblings, 2 replies; 5+ messages in thread
From: Yangtao Li @ 2018-11-20 16:14 UTC (permalink / raw)
To: rjw, daniel.lezcano, lorenzo.pieralisi
Cc: linux-pm, linux-arm-kernel, linux-kernel, Yangtao Li
of_find_node_by_path() acquires a reference to the node
returned by it and that reference needs to be dropped by its caller.
bl_idle_init() doesn't do that, so fix it.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
Changes in v3:
-update changelog
---
drivers/cpuidle/cpuidle-big_little.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
index db2ede565f1a..650f063ef809 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -174,8 +174,12 @@ static int __init bl_idle_init(void)
/*
* Initialize the driver just for a compliant set of machines
*/
- if (!of_match_node(compatible_machine_match, root))
+ if (!of_match_node(compatible_machine_match, root)){
+ of_node_put(root);
return -ENODEV;
+ }
+
+ of_node_put(root);
if (!mcpm_is_available())
return -EUNATCH;
--
2.17.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v3] cpuidle: big.LITTLE: add of_node_put()
2018-11-20 16:14 [PATCH v3] cpuidle: big.LITTLE: add of_node_put() Yangtao Li
@ 2018-12-09 6:20 ` Frank Lee
2018-12-10 11:31 ` Rafael J. Wysocki
2018-12-10 11:59 ` Daniel Lezcano
1 sibling, 1 reply; 5+ messages in thread
From: Frank Lee @ 2018-12-09 6:20 UTC (permalink / raw)
To: rjw, Daniel Lezcano, lorenzo.pieralisi
Cc: linux-pm, linux-arm-kernel, linux-kernel
On Wed, Nov 21, 2018 at 12:14 AM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> Changes in v3:
> -update changelog
> ---
> drivers/cpuidle/cpuidle-big_little.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> index db2ede565f1a..650f063ef809 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -174,8 +174,12 @@ static int __init bl_idle_init(void)
> /*
> * Initialize the driver just for a compliant set of machines
> */
> - if (!of_match_node(compatible_machine_match, root))
> + if (!of_match_node(compatible_machine_match, root)){
> + of_node_put(root);
> return -ENODEV;
> + }
> +
> + of_node_put(root);
>
> if (!mcpm_is_available())
> return -EUNATCH;
> --
> 2.17.0
>
ping......
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] cpuidle: big.LITTLE: add of_node_put()
2018-12-09 6:20 ` Frank Lee
@ 2018-12-10 11:31 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2018-12-10 11:31 UTC (permalink / raw)
To: Frank Lee
Cc: Daniel Lezcano, lorenzo.pieralisi, linux-pm, linux-arm-kernel,
linux-kernel
On Sunday, December 9, 2018 7:20:26 AM CET Frank Lee wrote:
> On Wed, Nov 21, 2018 at 12:14 AM Yangtao Li <tiny.windzz@gmail.com> wrote:
> >
> > of_find_node_by_path() acquires a reference to the node
> > returned by it and that reference needs to be dropped by its caller.
> > bl_idle_init() doesn't do that, so fix it.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Changes in v3:
> > -update changelog
> > ---
> > drivers/cpuidle/cpuidle-big_little.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> > index db2ede565f1a..650f063ef809 100644
> > --- a/drivers/cpuidle/cpuidle-big_little.c
> > +++ b/drivers/cpuidle/cpuidle-big_little.c
> > @@ -174,8 +174,12 @@ static int __init bl_idle_init(void)
> > /*
> > * Initialize the driver just for a compliant set of machines
> > */
> > - if (!of_match_node(compatible_machine_match, root))
> > + if (!of_match_node(compatible_machine_match, root)){
> > + of_node_put(root);
> > return -ENODEV;
> > + }
> > +
> > + of_node_put(root);
> >
> > if (!mcpm_is_available())
> > return -EUNATCH;
> > --
> > 2.17.0
> >
> ping......
I've been waiting for the maintainers of this driver to speak up.
I'll pick up the patch later today or tomorrow unless there are objections.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] cpuidle: big.LITTLE: add of_node_put()
2018-11-20 16:14 [PATCH v3] cpuidle: big.LITTLE: add of_node_put() Yangtao Li
2018-12-09 6:20 ` Frank Lee
@ 2018-12-10 11:59 ` Daniel Lezcano
2018-12-10 16:27 ` Frank Lee
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Lezcano @ 2018-12-10 11:59 UTC (permalink / raw)
To: Yangtao Li, rjw, lorenzo.pieralisi
Cc: linux-pm, linux-arm-kernel, linux-kernel
Hi Yangtao,
On 20/11/2018 17:14, Yangtao Li wrote:
> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> Changes in v3:
> -update changelog
> ---
> drivers/cpuidle/cpuidle-big_little.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> index db2ede565f1a..650f063ef809 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -174,8 +174,12 @@ static int __init bl_idle_init(void)
> /*
> * Initialize the driver just for a compliant set of machines
> */
> - if (!of_match_node(compatible_machine_match, root))
> + if (!of_match_node(compatible_machine_match, root)){
> + of_node_put(root);
> return -ENODEV;
> + }
> +
> + of_node_put(root);
Don't duplicate the of_node_put.
I suggest:
const struct of_device_id *match_id;
[ ... ]
match_id = of_match_node(compatible_machine_match, root);
of_node_put(root);
if (!match_id)
return -ENODEV;
> if (!mcpm_is_available())
> return -EUNATCH;
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] cpuidle: big.LITTLE: add of_node_put()
2018-12-10 11:59 ` Daniel Lezcano
@ 2018-12-10 16:27 ` Frank Lee
0 siblings, 0 replies; 5+ messages in thread
From: Frank Lee @ 2018-12-10 16:27 UTC (permalink / raw)
To: Daniel Lezcano
Cc: rjw, lorenzo.pieralisi, linux-pm, linux-arm-kernel, linux-kernel
On Mon, Dec 10, 2018 at 7:59 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
>
> Hi Yangtao,
>
>
> On 20/11/2018 17:14, Yangtao Li wrote:
> > of_find_node_by_path() acquires a reference to the node
> > returned by it and that reference needs to be dropped by its caller.
> > bl_idle_init() doesn't do that, so fix it.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Changes in v3:
> > -update changelog
> > ---
> > drivers/cpuidle/cpuidle-big_little.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> > index db2ede565f1a..650f063ef809 100644
> > --- a/drivers/cpuidle/cpuidle-big_little.c
> > +++ b/drivers/cpuidle/cpuidle-big_little.c
> > @@ -174,8 +174,12 @@ static int __init bl_idle_init(void)
> > /*
> > * Initialize the driver just for a compliant set of machines
> > */
> > - if (!of_match_node(compatible_machine_match, root))
> > + if (!of_match_node(compatible_machine_match, root)){
> > + of_node_put(root);
> > return -ENODEV;
> > + }
> > +
> > + of_node_put(root);
>
> Don't duplicate the of_node_put.
>
> I suggest:
>
> const struct of_device_id *match_id;
>
> [ ... ]
>
>
> match_id = of_match_node(compatible_machine_match, root);
>
> of_node_put(root);
>
> if (!match_id)
> return -ENODEV;
>
>
Thank you for your suggestion, the new one has been sent.
Yours,
Yangtao
> > if (!mcpm_is_available())
> > return -EUNATCH;
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-10 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 16:14 [PATCH v3] cpuidle: big.LITTLE: add of_node_put() Yangtao Li
2018-12-09 6:20 ` Frank Lee
2018-12-10 11:31 ` Rafael J. Wysocki
2018-12-10 11:59 ` Daniel Lezcano
2018-12-10 16:27 ` Frank Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).