From: Jayesh Choudhary <j-choudhary@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <broonie@kernel.org>,
<devicetree@vger.kernel.org>, <lgirdwood@gmail.com>,
<robh+dt@kernel.org>, <peter.ujfalusi@gmail.com>,
<alsa-devel@alsa-project.org>
Subject: Re: [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema
Date: Mon, 10 Jan 2022 12:51:28 +0530 [thread overview]
Message-ID: <ed22462f-7e71-85e6-8d97-cbaf533fa0d5@ti.com> (raw)
In-Reply-To: <1641218339.997415.2378536.nullmailer@robh.at.kernel.org>
On 03/01/22 7:28 pm, Rob Herring wrote:
> On Mon, 03 Jan 2022 13:14:27 +0530, Jayesh Choudhary wrote:
>> Convert the bindings for McASP controllers for TI SOCs from txt
>> to YAML schema.
>>
>> Adds additional properties 'clocks', 'clock-names', 'power-domains',
>> '#sound-dai-cells' and 'port' which were missing from the txt file.
>> Removes properties 'sram-size-playback' and 'sram-size-capture'
>> since they are not used.
>> Adds 'dmas' and 'dma-names' in the example which were missing from
>> the txt file.
>> Changes 'interrupts' and 'interrupt-names' from optional to
>> required properties.
>> Changes 'op-modes', 'serial-dir' to optional properties as they are
>> not needed if the McASP is used only as GPIO.
>> Changes 'tdm-slots' to required property only for I2S operation mode.
>>
>> Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS
>> INSTRUMENTS ASoC DRIVERS'
>>
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> ---
>> .../bindings/sound/davinci-mcasp-audio.txt | 86 --------
>> .../bindings/sound/davinci-mcasp-audio.yaml | 201 ++++++++++++++++++
>> MAINTAINERS | 1 +
>> 3 files changed, 202 insertions(+), 86 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.txt
>> create mode 100644 Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1574696
>
>
> mcasp@0: 'num-serializer' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/am335x-cm-t335.dt.yaml
> arch/arm/boot/dts/am335x-sbc-t335.dt.yaml
>
This is an error in the dts file. It has not been updated.
As pointed out by Peter, this property was removed by the commit ID:
1427e660b49e87cd842dba94158b0fc73030c17e
> mcasp@0: 'rt-num-evt' does not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/am335x-wega-rdk.dt.yaml
>
> mcasp@2b00000: 'tdm-slots' is a required property
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
>
> mcasp@2b10000: 'tdm-slots' is a required property
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
>
> mcasp@2b20000: 'tdm-slots' is a required property
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced.dt.yaml
> arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dt.yaml
>
Patches to fix the above errors have already been applied to linux-next
tree.
Links:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=277ee96f89d806f110e3011ea324155dd69e798f
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=29a5e8496b3ac0d400dfe32288c26c774beb8cc8
I re-ran the checks with the latest dt_schema. I didn't see these errors.
- Jayesh
next prev parent reply other threads:[~2022-01-10 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 7:44 [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Jayesh Choudhary
2022-01-03 13:58 ` Rob Herring
2022-01-10 7:21 ` Jayesh Choudhary [this message]
2022-01-11 2:28 ` Rob Herring
2022-01-11 19:21 ` Péter Ujfalusi
2022-01-11 19:43 ` Péter Ujfalusi
2022-01-17 10:07 ` Jayesh Choudhary
2022-01-28 20:18 ` Péter Ujfalusi
2022-02-08 16:20 ` Jayesh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed22462f-7e71-85e6-8d97-cbaf533fa0d5@ti.com \
--to=j-choudhary@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).