From: Jayesh Choudhary <j-choudhary@ti.com>
To: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>, robh+dt@kernel.org
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>,
<alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema
Date: Mon, 17 Jan 2022 15:37:16 +0530 [thread overview]
Message-ID: <f2bf4959-af15-04ad-78c3-aca883173d65@ti.com> (raw)
In-Reply-To: <83c51ee4-ac10-0e44-d1cc-f69cebcbf0b8@gmail.com>
On 12/01/22 1:13 am, Péter Ujfalusi wrote:
>
>
> On 1/11/22 21:21, Péter Ujfalusi wrote:
>> Hi Javesh,
>>
>> On 03/01/2022 09:44, Jayesh Choudhary wrote:
>>> Convert the bindings for McASP controllers for TI SOCs from txt
>>> to YAML schema.
>>>
>>> Adds additional properties 'clocks', 'clock-names', 'power-domains',
>>> '#sound-dai-cells' and 'port' which were missing from the txt file.
>>> Removes properties 'sram-size-playback' and 'sram-size-capture'
>>> since they are not used.
>>> Adds 'dmas' and 'dma-names' in the example which were missing from
>>> the txt file.
>>> Changes 'interrupts' and 'interrupt-names' from optional to
>>> required properties.
>>> Changes 'op-modes', 'serial-dir' to optional properties as they are
>>> not needed if the McASP is used only as GPIO.
>>> Changes 'tdm-slots' to required property only for I2S operation mode.
>>>
>>> Adds the yaml file in the 'MAINTAINERS' under the heading 'TEXAS
>>> INSTRUMENTS ASoC DRIVERS'
>>
>> I would have added description for the GPIO support as it is not obvious
>> that 2 is going to be for AXR2 or 29 is for ACLKR pin.
>> But I don't think this functionality is going to be used apart from the
>> one dra7 evm.
>>
>> Thank you for the updates and the nice work!
>>
>> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>>
> ...
>
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - ti,dm646x-mcasp-audio
>>> + - ti,da830-mcasp-audio
>>> + - ti,am33xx-mcasp-audio
>>> + - ti,dra7-mcasp-audio
>>> + - ti,omap4-mcasp-audio
>
> This is the only thing which bugs me: the pointless '-audio' postfix for
> the compatible string...
>
Removing the postfix would also require a lot of dts changes which might
be backward incompatible. So it is probably not a good idea.
Should we still consider this?
next prev parent reply other threads:[~2022-01-17 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 7:44 [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Jayesh Choudhary
2022-01-03 13:58 ` Rob Herring
2022-01-10 7:21 ` Jayesh Choudhary
2022-01-11 2:28 ` Rob Herring
2022-01-11 19:21 ` Péter Ujfalusi
2022-01-11 19:43 ` Péter Ujfalusi
2022-01-17 10:07 ` Jayesh Choudhary [this message]
2022-01-28 20:18 ` Péter Ujfalusi
2022-02-08 16:20 ` Jayesh Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2bf4959-af15-04ad-78c3-aca883173d65@ti.com \
--to=j-choudhary@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).