* [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
@ 2020-06-08 2:53 Qian Cai
2020-06-08 3:14 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Qian Cai @ 2020-06-08 2:53 UTC (permalink / raw)
To: laurent.pinchart, kieran.bingham+renesas
Cc: airlied, daniel, dri-devel, linux-renesas-soc, linux-kernel, Qian Cai
There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
the generated .config a bit ugly.
# ARM devices
#
# end of ARM devices
CONFIG_DRM_RCAR_WRITEBACK=y
#
# Frame buffer Devices
Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
Signed-off-by: Qian Cai <cai@lca.pw>
---
drivers/gpu/drm/rcar-du/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index 0919f1f159a4..3304b41f5611 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -48,3 +48,4 @@ config DRM_RCAR_VSP
config DRM_RCAR_WRITEBACK
bool
default y if ARM64
+ depends on DRM_RCAR_DU
--
2.21.0 (Apple Git-122.2)
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 2:53 [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM Qian Cai
@ 2020-06-08 3:14 ` Laurent Pinchart
2020-06-08 3:16 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2020-06-08 3:14 UTC (permalink / raw)
To: Qian Cai
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
Hi Qian,
Thank you for the patch.
On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
> There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
s/DRM=n/DRM_RCAR_DU=n/ here.
> the generated .config a bit ugly.
>
> # ARM devices
> #
> # end of ARM devices
>
> CONFIG_DRM_RCAR_WRITEBACK=y
>
> #
> # Frame buffer Devices
>
> Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
No need to submit a v3 if you agree with the above change, I'll fix it
in my tree.
> ---
> drivers/gpu/drm/rcar-du/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> index 0919f1f159a4..3304b41f5611 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -48,3 +48,4 @@ config DRM_RCAR_VSP
> config DRM_RCAR_WRITEBACK
> bool
> default y if ARM64
> + depends on DRM_RCAR_DU
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 3:14 ` Laurent Pinchart
@ 2020-06-08 3:16 ` Laurent Pinchart
2020-06-08 4:30 ` Qian Cai
2020-08-22 1:20 ` Qian Cai
0 siblings, 2 replies; 7+ messages in thread
From: Laurent Pinchart @ 2020-06-08 3:16 UTC (permalink / raw)
To: Qian Cai
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
> On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
> > There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
>
> s/DRM=n/DRM_RCAR_DU=n/ here.
>
> > the generated .config a bit ugly.
> >
> > # ARM devices
> > #
> > # end of ARM devices
> >
> > CONFIG_DRM_RCAR_WRITEBACK=y
> >
> > #
> > # Frame buffer Devices
> >
> > Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
> >
> > Signed-off-by: Qian Cai <cai@lca.pw>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> No need to submit a v3 if you agree with the above change, I'll fix it
> in my tree.
>
> > ---
> > drivers/gpu/drm/rcar-du/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > index 0919f1f159a4..3304b41f5611 100644
> > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > @@ -48,3 +48,4 @@ config DRM_RCAR_VSP
> > config DRM_RCAR_WRITEBACK
> > bool
> > default y if ARM64
> > + depends on DRM_RCAR_DU
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 3:16 ` Laurent Pinchart
@ 2020-06-08 4:30 ` Qian Cai
2020-06-10 9:24 ` Kieran Bingham
2020-08-22 1:20 ` Qian Cai
1 sibling, 1 reply; 7+ messages in thread
From: Qian Cai @ 2020-06-08 4:30 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
> On Jun 7, 2020, at 11:16 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>
> I forgot to mention, I think the subject line should be
>
> drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
>
> Could you please let me know if you're OK with these two small changes ?
Yes, I am fine with those.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 4:30 ` Qian Cai
@ 2020-06-10 9:24 ` Kieran Bingham
0 siblings, 0 replies; 7+ messages in thread
From: Kieran Bingham @ 2020-06-10 9:24 UTC (permalink / raw)
To: Qian Cai, Laurent Pinchart
Cc: airlied, daniel, dri-devel, linux-renesas-soc, linux-kernel
Hi Qian, Laurent,
On 08/06/2020 05:30, Qian Cai wrote:
>
>
>> On Jun 7, 2020, at 11:16 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
>>
>> I forgot to mention, I think the subject line should be
>>
>> drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
>>
>> Could you please let me know if you're OK with these two small changes ?
>
> Yes, I am fine with those.
>
With the fixups,
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
--
Kieran
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-06-08 3:16 ` Laurent Pinchart
2020-06-08 4:30 ` Qian Cai
@ 2020-08-22 1:20 ` Qian Cai
2020-08-23 22:18 ` Laurent Pinchart
1 sibling, 1 reply; 7+ messages in thread
From: Qian Cai @ 2020-08-22 1:20 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote:
> Hi Qian,
>
> I forgot to mention, I think the subject line should be
>
> drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
>
> Could you please let me know if you're OK with these two small changes ?
Laurent, this patch is still not in the latest linux-next. Can you take a look?
>
> On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
> > On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
> > > There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
> >
> > s/DRM=n/DRM_RCAR_DU=n/ here.
> >
> > > the generated .config a bit ugly.
> > >
> > > # ARM devices
> > > #
> > > # end of ARM devices
> > >
> > > CONFIG_DRM_RCAR_WRITEBACK=y
> > >
> > > #
> > > # Frame buffer Devices
> > >
> > > Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
> > >
> > > Signed-off-by: Qian Cai <cai@lca.pw>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > No need to submit a v3 if you agree with the above change, I'll fix it
> > in my tree.
> >
> > > ---
> > > drivers/gpu/drm/rcar-du/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > > index 0919f1f159a4..3304b41f5611 100644
> > > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > > @@ -48,3 +48,4 @@ config DRM_RCAR_VSP
> > > config DRM_RCAR_WRITEBACK
> > > bool
> > > default y if ARM64
> > > + depends on DRM_RCAR_DU
>
> --
> Regards,
>
> Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM
2020-08-22 1:20 ` Qian Cai
@ 2020-08-23 22:18 ` Laurent Pinchart
0 siblings, 0 replies; 7+ messages in thread
From: Laurent Pinchart @ 2020-08-23 22:18 UTC (permalink / raw)
To: Qian Cai
Cc: kieran.bingham+renesas, airlied, daniel, dri-devel,
linux-renesas-soc, linux-kernel
Hi Qian,
On Fri, Aug 21, 2020 at 09:20:37PM -0400, Qian Cai wrote:
> On Mon, Jun 08, 2020 at 06:16:22AM +0300, Laurent Pinchart wrote:
> > Hi Qian,
> >
> > I forgot to mention, I think the subject line should be
> >
> > drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
> >
> > Could you please let me know if you're OK with these two small changes ?
>
> Laurent, this patch is still not in the latest linux-next. Can you take a look?
Sorry for the delay. It will be included in the pull request I send this
week.
> > On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
> > > On Sun, Jun 07, 2020 at 10:53:40PM -0400, Qian Cai wrote:
> > > > There is no need to select DRM_RCAR_WRITEBACK if DRM=n which just make
> > >
> > > s/DRM=n/DRM_RCAR_DU=n/ here.
> > >
> > > > the generated .config a bit ugly.
> > > >
> > > > # ARM devices
> > > > #
> > > > # end of ARM devices
> > > >
> > > > CONFIG_DRM_RCAR_WRITEBACK=y
> > > >
> > > > #
> > > > # Frame buffer Devices
> > > >
> > > > Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
> > > >
> > > > Signed-off-by: Qian Cai <cai@lca.pw>
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > > No need to submit a v3 if you agree with the above change, I'll fix it
> > > in my tree.
> > >
> > > > ---
> > > > drivers/gpu/drm/rcar-du/Kconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
> > > > index 0919f1f159a4..3304b41f5611 100644
> > > > --- a/drivers/gpu/drm/rcar-du/Kconfig
> > > > +++ b/drivers/gpu/drm/rcar-du/Kconfig
> > > > @@ -48,3 +48,4 @@ config DRM_RCAR_VSP
> > > > config DRM_RCAR_WRITEBACK
> > > > bool
> > > > default y if ARM64
> > > > + depends on DRM_RCAR_DU
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-23 22:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 2:53 [PATCH v2] drm/rcar-du: DRM_RCAR_WRITEBACK depends on DRM Qian Cai
2020-06-08 3:14 ` Laurent Pinchart
2020-06-08 3:16 ` Laurent Pinchart
2020-06-08 4:30 ` Qian Cai
2020-06-10 9:24 ` Kieran Bingham
2020-08-22 1:20 ` Qian Cai
2020-08-23 22:18 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).