linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Fathi Boudra <fathi.boudra@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Pratyush Anand <panand@redhat.com>,
	linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
Date: Wed, 19 Apr 2017 14:22:07 -0600	[thread overview]
Message-ID: <ed9fc184-c564-d65e-7164-1ce1eb37d017@kernel.org> (raw)
In-Reply-To: <CAGNsrLAVOUq2cDcYo1WGFweCkO2LaSV71cXDGhh4Kg2nPDHRLw@mail.gmail.com>

On 04/19/2017 11:31 AM, Fathi Boudra wrote:
> gentle ping
> 
> On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
>> It covers only the native build because it's computed from uname -m output.
>> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
>> the test.
>> Fix the test to allow both native and cross-compilation of the test.
>>
>> Note: glibc is missing several of the TRAP_* constants in the userspace
>>       definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
>>       See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>

I plan to get to it towards the end of this week. Thanks for
the ping.

-- Shuah

>> ---
>>  tools/testing/selftests/breakpoints/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
>> index 72aa103e4141..6b214b7b10fb 100644
>> --- a/tools/testing/selftests/breakpoints/Makefile
>> +++ b/tools/testing/selftests/breakpoints/Makefile
>> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>>  ifeq ($(ARCH),x86)
>>  TEST_GEN_PROGS := breakpoint_test
>>  endif
>> -ifeq ($(ARCH),aarch64)
>> +ifneq (,$(filter $(ARCH),aarch64 arm64))
>>  TEST_GEN_PROGS := breakpoint_test_arm64
>>  endif
>>
>> --
>> 2.11.0
>>
> 
> 

  reply	other threads:[~2017-04-19 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 18:04 Fathi Boudra
2017-03-30 12:23 ` Naresh Kamboju
2017-04-19 17:31 ` Fathi Boudra
2017-04-19 20:22   ` Shuah Khan [this message]
2017-04-27 13:44   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed9fc184-c564-d65e-7164-1ce1eb37d017@kernel.org \
    --to=shuah@kernel.org \
    --cc=fathi.boudra@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=panand@redhat.com \
    --subject='Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).