* [PATCH v4] cpuidle: big.LITTLE: fix refcount leak
@ 2018-12-10 16:26 Yangtao Li
2018-12-10 17:00 ` Daniel Lezcano
0 siblings, 1 reply; 3+ messages in thread
From: Yangtao Li @ 2018-12-10 16:26 UTC (permalink / raw)
To: lorenzo.pieralisi, daniel.lezcano, rjw
Cc: linux-pm, linux-arm-kernel, linux-kernel, Yangtao Li
of_find_node_by_path() acquires a reference to the node
returned by it and that reference needs to be dropped by its caller.
bl_idle_init() doesn't do that, so fix it.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
changes in v4:
-update tile
-refactor code,suggested by Daniel
---
drivers/cpuidle/cpuidle-big_little.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
index db2ede565f1a..b44476a1b7ad 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -167,6 +167,7 @@ static int __init bl_idle_init(void)
{
int ret;
struct device_node *root = of_find_node_by_path("/");
+ const struct of_device_id *match_id;
if (!root)
return -ENODEV;
@@ -174,7 +175,11 @@ static int __init bl_idle_init(void)
/*
* Initialize the driver just for a compliant set of machines
*/
- if (!of_match_node(compatible_machine_match, root))
+ match_id = of_match_node(compatible_machine_match, root);
+
+ of_node_put(root);
+
+ if (!match_id)
return -ENODEV;
if (!mcpm_is_available())
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v4] cpuidle: big.LITTLE: fix refcount leak
2018-12-10 16:26 [PATCH v4] cpuidle: big.LITTLE: fix refcount leak Yangtao Li
@ 2018-12-10 17:00 ` Daniel Lezcano
2018-12-17 11:42 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lezcano @ 2018-12-10 17:00 UTC (permalink / raw)
To: Yangtao Li, lorenzo.pieralisi, rjw
Cc: linux-pm, linux-arm-kernel, linux-kernel
On 10/12/2018 17:26, Yangtao Li wrote:
> of_find_node_by_path() acquires a reference to the node
> returned by it and that reference needs to be dropped by its caller.
> bl_idle_init() doesn't do that, so fix it.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> changes in v4:
> -update tile
> -refactor code,suggested by Daniel
> ---
> drivers/cpuidle/cpuidle-big_little.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> index db2ede565f1a..b44476a1b7ad 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -167,6 +167,7 @@ static int __init bl_idle_init(void)
> {
> int ret;
> struct device_node *root = of_find_node_by_path("/");
> + const struct of_device_id *match_id;
>
> if (!root)
> return -ENODEV;
> @@ -174,7 +175,11 @@ static int __init bl_idle_init(void)
> /*
> * Initialize the driver just for a compliant set of machines
> */
> - if (!of_match_node(compatible_machine_match, root))
> + match_id = of_match_node(compatible_machine_match, root);
> +
> + of_node_put(root);
> +
> + if (!match_id)
> return -ENODEV;
>
> if (!mcpm_is_available())
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] cpuidle: big.LITTLE: fix refcount leak
2018-12-10 17:00 ` Daniel Lezcano
@ 2018-12-17 11:42 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-12-17 11:42 UTC (permalink / raw)
To: Daniel Lezcano, Yangtao Li
Cc: lorenzo.pieralisi, linux-pm, linux-arm-kernel, linux-kernel
On Monday, December 10, 2018 6:00:12 PM CET Daniel Lezcano wrote:
> On 10/12/2018 17:26, Yangtao Li wrote:
> > of_find_node_by_path() acquires a reference to the node
> > returned by it and that reference needs to be dropped by its caller.
> > bl_idle_init() doesn't do that, so fix it.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> > ---
> > changes in v4:
> > -update tile
> > -refactor code,suggested by Daniel
> > ---
> > drivers/cpuidle/cpuidle-big_little.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> > index db2ede565f1a..b44476a1b7ad 100644
> > --- a/drivers/cpuidle/cpuidle-big_little.c
> > +++ b/drivers/cpuidle/cpuidle-big_little.c
> > @@ -167,6 +167,7 @@ static int __init bl_idle_init(void)
> > {
> > int ret;
> > struct device_node *root = of_find_node_by_path("/");
> > + const struct of_device_id *match_id;
> >
> > if (!root)
> > return -ENODEV;
> > @@ -174,7 +175,11 @@ static int __init bl_idle_init(void)
> > /*
> > * Initialize the driver just for a compliant set of machines
> > */
> > - if (!of_match_node(compatible_machine_match, root))
> > + match_id = of_match_node(compatible_machine_match, root);
> > +
> > + of_node_put(root);
> > +
> > + if (!match_id)
> > return -ENODEV;
> >
> > if (!mcpm_is_available())
> >
>
>
>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-17 11:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-10 16:26 [PATCH v4] cpuidle: big.LITTLE: fix refcount leak Yangtao Li
2018-12-10 17:00 ` Daniel Lezcano
2018-12-17 11:42 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).