* [PATCH 1/1] gpn: drm: fsl_tcon: add missing of_node_put after calling of_parse_phandle
@ 2016-07-04 7:40 Peter Chen
2016-07-14 5:50 ` Stefan Agner
0 siblings, 1 reply; 2+ messages in thread
From: Peter Chen @ 2016-07-04 7:40 UTC (permalink / raw)
To: airlied; +Cc: stefan, alison.wang, dri-devel, linux-kernel, Peter Chen
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using, but current code only
calls it at error path, fix it by adding it at correct code path.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
index bbe34f1..bca09ea 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
@@ -92,6 +92,7 @@ struct fsl_tcon *fsl_tcon_init(struct device *dev)
goto err_node_put;
}
+ of_node_put(np);
clk_prepare_enable(tcon->ipg_clk);
dev_info(dev, "Using TCON in bypass mode\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] gpn: drm: fsl_tcon: add missing of_node_put after calling of_parse_phandle
2016-07-04 7:40 [PATCH 1/1] gpn: drm: fsl_tcon: add missing of_node_put after calling of_parse_phandle Peter Chen
@ 2016-07-14 5:50 ` Stefan Agner
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Agner @ 2016-07-14 5:50 UTC (permalink / raw)
To: Peter Chen; +Cc: airlied, alison.wang, dri-devel, linux-kernel
On 2016-07-04 00:40, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using, but current code only
> calls it at error path, fix it by adding it at correct code path.
>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/gpu/drm/fsl-dcu/fsl_tcon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> index bbe34f1..bca09ea 100644
> --- a/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> +++ b/drivers/gpu/drm/fsl-dcu/fsl_tcon.c
> @@ -92,6 +92,7 @@ struct fsl_tcon *fsl_tcon_init(struct device *dev)
> goto err_node_put;
> }
>
> + of_node_put(np);
> clk_prepare_enable(tcon->ipg_clk);
>
> dev_info(dev, "Using TCON in bypass mode\n");
Thanks, applied!
Changed subject prefix using the usual drm/fsl-dcu:...
--
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-14 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 7:40 [PATCH 1/1] gpn: drm: fsl_tcon: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-14 5:50 ` Stefan Agner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).