From: Leonard Crestez <leonard.crestez@nxp.com>
To: "stefan@agner.ch" <stefan@agner.ch>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"tpiepho@impinj.com" <tpiepho@impinj.com>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] PCI: imx6: limit DBI register length
Date: Mon, 26 Nov 2018 10:16:04 +0000 [thread overview]
Message-ID: <ee74fde8e40a0ca40bd8b69755c9b0919f779b13.camel@nxp.com> (raw)
In-Reply-To: <268e109e1c6b309454bd5a313078894c@agner.ch>
On Tue, 2018-11-20 at 21:42 +0100, Stefan Agner wrote:
> On 20.11.2018 20:13, Trent Piepho wrote:
> > On Tue, 2018-11-20 at 18:19 +0000, Leonard Crestez wrote:
> > > On Tue, 2018-11-20 at 17:56 +0100, Stefan Agner wrote:
> > > > Define the length of the DBI registers. This makes sure that
> > > > the kernel does not access registers beyond that point, avoiding
> > > > the following abort on a i.MX 6Quad:
> > > > # cat
> > > > /sys/devices/soc0/soc/1ffc000.pcie/pci0000\:00/0000\:00\:00.0/config
> > > > [ 100.021433] Unhandled fault: imprecise external abort (0x1406)
> > > > at 0xb6ea7000
> > > > ...
> > > > [ 100.056423] PC is at dw_pcie_read+0x50/0x84
> > > > [ 100.060790] LR is at dw_pcie_rd_own_conf+0x44/0x48
> > >
> > > I don't know exactly where this limitation comes from, I can indeed
> > > reproduce a stack dump when dumping pci config from /sys/
> > >
> > > Unfortunately this seems to block access to registers used for
> > > functionality like interrupts. For example dw_handle_msi_irq does:
> > >
> > > dw_pcie_rd_own_conf(pp, PCIE_MSI_INTR0_STATUS +
> > > (i * MSI_REG_CTRL_BLOCK_SIZE),
> > > 4, &val);
> > >
> > > where PCI_MSI_INTR0_STATUS is 0x830. There are more accesses like this.
> >
> > On IMX7d, there are significant blocks of 00s in the config space, and
> > all 0xff at 0xb50 on up.
> >
> > I.e., significant portions are empty, in the middle of the config
> > space, not just at the end.
> >
> > But they can be read without problem.
> >
> > Perhaps imx6q aborts on a read of an unimplemented address instead of
> > returning zeros like imx7d. In that case it really needs something
> > more complex to prevent abort than just a length.
>
> Yeah it seems those SoCs behave differently.
>
> Describing a register set with holes will get complicated, I guess it
> would ask for a regmap...
The PortLogic area seems to be always at 0x700-0xA00, there are defines
for it. So this would only require one additional range, no regmap
stuff.
I don't know if making portlogic accessible to userspace is useful. In
theory somebody could read debug DWC registers via /sys/blah/config,
but there are better ways to read HW registers from userspace.
Browsing through the docs I can't find stuff like reads with side-
effects so I can't say that it's harmful either.
> > It also seems to me that this doesn't need to be in the internal pci
> > config access functions. The driver shouldn't be reading registers
> > that don't exist anyway. It's really about trying to fix sysfs access
> > to registers that don't exist. So maybe it should be done there.
>
> That was my first approach
Doing it on a per-soc basis is better, this seems to affect both 6q and
6qp (those are distinct!) but not others.
The pci config area from userspace is accessed through pci_ops.read =
dw_pcie_rd_conf while internal accesses go through dw_pcie_rd_own_conf.
So moving the dbi_length check up one level would work easily.
What about assigning to pci_dev->cfg_size from probe code?
Unfortunately there doesn't seem to be any straight-forward way to do
that from imx6_pcie or even dw_pcie, but maybe I'm missing something?
--
Regards,
Leonard
next prev parent reply other threads:[~2018-11-26 10:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 16:56 [PATCH v3 1/2] PCI: imx6: introduce drvdata Stefan Agner
2018-11-20 16:56 ` [PATCH v3 2/2] PCI: imx6: limit DBI register length Stefan Agner
2018-11-20 18:19 ` Leonard Crestez
2018-11-20 19:13 ` Trent Piepho
2018-11-20 20:42 ` Stefan Agner
2018-11-20 21:28 ` Trent Piepho
2018-11-21 13:47 ` Leonard Crestez
2018-11-21 14:17 ` Lorenzo Pieralisi
2018-11-28 12:19 ` Stefan Agner
2018-11-28 17:36 ` Stefan Agner
2018-11-28 17:50 ` Lucas Stach
2018-11-28 17:56 ` Stefan Agner
2018-11-28 18:01 ` Leonard Crestez
2018-11-26 10:16 ` Leonard Crestez [this message]
2018-11-26 16:34 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee74fde8e40a0ca40bd8b69755c9b0919f779b13.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=stefan@agner.ch \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).