* [PATCH] eCryptfs: constify attribute_group structures.
@ 2017-06-30 9:33 Arvind Yadav
2017-10-14 1:27 ` Tyler Hicks
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-30 9:33 UTC (permalink / raw)
To: tyhicks, viro; +Cc: ecryptfs, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
6122 636 24 6782 1a7e fs/ecryptfs/main.o
File size After adding 'const':
text data bss dec hex filename
6186 604 24 6814 1a9e fs/ecryptfs/main.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
fs/ecryptfs/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index 9014479..eea4c0f 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj,
NULL,
};
-static struct attribute_group attr_group = {
+static const struct attribute_group attr_group = {
.attrs = attributes,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] eCryptfs: constify attribute_group structures.
2017-06-30 9:33 [PATCH] eCryptfs: constify attribute_group structures Arvind Yadav
@ 2017-10-14 1:27 ` Tyler Hicks
0 siblings, 0 replies; 2+ messages in thread
From: Tyler Hicks @ 2017-10-14 1:27 UTC (permalink / raw)
To: Arvind Yadav, viro; +Cc: ecryptfs, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1220 bytes --]
Hi Arvind - My apologies for the extremely slow review.
On 06/30/2017 05:33 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 6122 636 24 6782 1a7e fs/ecryptfs/main.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 6186 604 24 6814 1a9e fs/ecryptfs/main.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
This patch looks good. I'll get it queued up for 4.15.
Tyler
> ---
> fs/ecryptfs/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
> index 9014479..eea4c0f 100644
> --- a/fs/ecryptfs/main.c
> +++ b/fs/ecryptfs/main.c
> @@ -782,7 +782,7 @@ static ssize_t version_show(struct kobject *kobj,
> NULL,
> };
>
> -static struct attribute_group attr_group = {
> +static const struct attribute_group attr_group = {
> .attrs = attributes,
> };
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-14 1:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-30 9:33 [PATCH] eCryptfs: constify attribute_group structures Arvind Yadav
2017-10-14 1:27 ` Tyler Hicks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).