linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc
@ 2016-08-17 10:44 Roger Quadros
  2016-08-17 10:44 ` [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration Roger Quadros
  2016-08-17 16:24 ` [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc Santosh Shilimkar
  0 siblings, 2 replies; 7+ messages in thread
From: Roger Quadros @ 2016-08-17 10:44 UTC (permalink / raw)
  To: ssantosh
  Cc: balbi, grygorii.strashko, linux-arm-kernel, linux-kernel, Roger Quadros

Hi Santosh,

USB ports are broken on Keystone2 boards since v4.8-rc1.
This is because CONFIG_KEYSTONE_USB_PHY is no longer being enabled
by keystone_defconfig. Fix that.

Please pick this for the v4.8-rc cycle. Thanks.

cheers,
-roger

Roger Quadros (1):
  ARM: keystone: defconfig: Fix USB configuration

 arch/arm/configs/keystone_defconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration
  2016-08-17 10:44 [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc Roger Quadros
@ 2016-08-17 10:44 ` Roger Quadros
  2016-08-17 16:23   ` Santosh Shilimkar
  2016-08-17 16:24 ` [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc Santosh Shilimkar
  1 sibling, 1 reply; 7+ messages in thread
From: Roger Quadros @ 2016-08-17 10:44 UTC (permalink / raw)
  To: ssantosh
  Cc: balbi, grygorii.strashko, linux-arm-kernel, linux-kernel, Roger Quadros

Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore
as it depends on CONFIG_NOP_USB_XCEIV. We need to enable
that as well.

This fixes USB on Keystone boards from v4.8-rc1 onwards.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/configs/keystone_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index 71b42e6..78cd2f1 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -161,6 +161,7 @@ CONFIG_USB_MON=y
 CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_DWC3=y
+CONFIG_NOP_USB_XCEIV=y
 CONFIG_KEYSTONE_USB_PHY=y
 CONFIG_NEW_LEDS=y
 CONFIG_LEDS_CLASS=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration
  2016-08-17 10:44 ` [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration Roger Quadros
@ 2016-08-17 16:23   ` Santosh Shilimkar
  2016-08-25 16:39     ` Santosh Shilimkar
  0 siblings, 1 reply; 7+ messages in thread
From: Santosh Shilimkar @ 2016-08-17 16:23 UTC (permalink / raw)
  To: Arnd Bergmann, Olof Johansson
  Cc: Roger Quadros, ssantosh, balbi, grygorii.strashko,
	linux-arm-kernel, linux-kernel

Hi Arnd, Olof,

Can you please pick-up the fix for 4.8-rcx ?
Roger reported that USB ports are broken on Keystone2 boards
since v4.8-rc1 because USB_HPY config option got dropped.


On 8/17/2016 3:44 AM, Roger Quadros wrote:
> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore
> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable
> that as well.
>
> This fixes USB on Keystone boards from v4.8-rc1 onwards.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>


>  arch/arm/configs/keystone_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
> index 71b42e6..78cd2f1 100644
> --- a/arch/arm/configs/keystone_defconfig
> +++ b/arch/arm/configs/keystone_defconfig
> @@ -161,6 +161,7 @@ CONFIG_USB_MON=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_STORAGE=y
>  CONFIG_USB_DWC3=y
> +CONFIG_NOP_USB_XCEIV=y
>  CONFIG_KEYSTONE_USB_PHY=y
>  CONFIG_NEW_LEDS=y
>  CONFIG_LEDS_CLASS=y
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc
  2016-08-17 10:44 [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc Roger Quadros
  2016-08-17 10:44 ` [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration Roger Quadros
@ 2016-08-17 16:24 ` Santosh Shilimkar
  1 sibling, 0 replies; 7+ messages in thread
From: Santosh Shilimkar @ 2016-08-17 16:24 UTC (permalink / raw)
  To: Roger Quadros, ssantosh
  Cc: balbi, grygorii.strashko, linux-arm-kernel, linux-kernel

On 8/17/2016 3:44 AM, Roger Quadros wrote:
> Hi Santosh,
>
> USB ports are broken on Keystone2 boards since v4.8-rc1.
> This is because CONFIG_KEYSTONE_USB_PHY is no longer being enabled
> by keystone_defconfig. Fix that.
>
> Please pick this for the v4.8-rc cycle. Thanks.

Have requested arm-soc folks to pick it up. Thanks for
the fix.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration
  2016-08-17 16:23   ` Santosh Shilimkar
@ 2016-08-25 16:39     ` Santosh Shilimkar
  2016-09-12 11:33       ` Roger Quadros
  0 siblings, 1 reply; 7+ messages in thread
From: Santosh Shilimkar @ 2016-08-25 16:39 UTC (permalink / raw)
  To: Arnd Bergmann, Olof Johansson
  Cc: Roger Quadros, ssantosh, balbi, grygorii.strashko,
	linux-arm-kernel, linux-kernel

Ping !!

On 8/17/2016 9:23 AM, Santosh Shilimkar wrote:
> Hi Arnd, Olof,
>
> Can you please pick-up the fix for 4.8-rcx ?
> Roger reported that USB ports are broken on Keystone2 boards
> since v4.8-rc1 because USB_HPY config option got dropped.
>
>
> On 8/17/2016 3:44 AM, Roger Quadros wrote:
>> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore
>> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable
>> that as well.
>>
>> This fixes USB on Keystone boards from v4.8-rc1 onwards.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
>
>
>>  arch/arm/configs/keystone_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/keystone_defconfig
>> b/arch/arm/configs/keystone_defconfig
>> index 71b42e6..78cd2f1 100644
>> --- a/arch/arm/configs/keystone_defconfig
>> +++ b/arch/arm/configs/keystone_defconfig
>> @@ -161,6 +161,7 @@ CONFIG_USB_MON=y
>>  CONFIG_USB_XHCI_HCD=y
>>  CONFIG_USB_STORAGE=y
>>  CONFIG_USB_DWC3=y
>> +CONFIG_NOP_USB_XCEIV=y
>>  CONFIG_KEYSTONE_USB_PHY=y
>>  CONFIG_NEW_LEDS=y
>>  CONFIG_LEDS_CLASS=y
>>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration
  2016-08-25 16:39     ` Santosh Shilimkar
@ 2016-09-12 11:33       ` Roger Quadros
  2016-09-15  9:47         ` Arnd Bergmann
  0 siblings, 1 reply; 7+ messages in thread
From: Roger Quadros @ 2016-09-12 11:33 UTC (permalink / raw)
  To: Santosh Shilimkar, Arnd Bergmann, Olof Johansson
  Cc: ssantosh, balbi, grygorii.strashko, linux-arm-kernel, linux-kernel

Hi,

On 25/08/16 19:39, Santosh Shilimkar wrote:
> Ping !!
> 
> On 8/17/2016 9:23 AM, Santosh Shilimkar wrote:
>> Hi Arnd, Olof,
>>
>> Can you please pick-up the fix for 4.8-rcx ?
>> Roger reported that USB ports are broken on Keystone2 boards
>> since v4.8-rc1 because USB_HPY config option got dropped.
>>
>>
>> On 8/17/2016 3:44 AM, Roger Quadros wrote:
>>> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore
>>> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable
>>> that as well.
>>>
>>> This fixes USB on Keystone boards from v4.8-rc1 onwards.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

Gentle reminder.
This is still missing in v4.8-rc6.

cheers,
-roger

>>
>>
>>>  arch/arm/configs/keystone_defconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/arch/arm/configs/keystone_defconfig
>>> b/arch/arm/configs/keystone_defconfig
>>> index 71b42e6..78cd2f1 100644
>>> --- a/arch/arm/configs/keystone_defconfig
>>> +++ b/arch/arm/configs/keystone_defconfig
>>> @@ -161,6 +161,7 @@ CONFIG_USB_MON=y
>>>  CONFIG_USB_XHCI_HCD=y
>>>  CONFIG_USB_STORAGE=y
>>>  CONFIG_USB_DWC3=y
>>> +CONFIG_NOP_USB_XCEIV=y
>>>  CONFIG_KEYSTONE_USB_PHY=y
>>>  CONFIG_NEW_LEDS=y
>>>  CONFIG_LEDS_CLASS=y
>>>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration
  2016-09-12 11:33       ` Roger Quadros
@ 2016-09-15  9:47         ` Arnd Bergmann
  0 siblings, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2016-09-15  9:47 UTC (permalink / raw)
  To: Roger Quadros
  Cc: Santosh Shilimkar, Olof Johansson, ssantosh, balbi,
	grygorii.strashko, linux-arm-kernel, linux-kernel

On Monday, September 12, 2016 2:33:57 PM CEST Roger Quadros wrote:
> On 25/08/16 19:39, Santosh Shilimkar wrote:
> > Ping !!
> > 
> > On 8/17/2016 9:23 AM, Santosh Shilimkar wrote:
> >> Hi Arnd, Olof,
> >>
> >> Can you please pick-up the fix for 4.8-rcx ?
> >> Roger reported that USB ports are broken on Keystone2 boards
> >> since v4.8-rc1 because USB_HPY config option got dropped.
> >>
> >>
> >> On 8/17/2016 3:44 AM, Roger Quadros wrote:
> >>> Simply enabling CONFIG_KEYSTONE_USB_PHY doesn't work anymore
> >>> as it depends on CONFIG_NOP_USB_XCEIV. We need to enable
> >>> that as well.
> >>>
> >>> This fixes USB on Keystone boards from v4.8-rc1 onwards.
> >>>
> >>> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >>> ---
> >> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
> 
> Gentle reminder.
> This is still missing in v4.8-rc6.
> 
> 

Applied to the fixes branch now, sorry for missing the
previous reminder.

	Arnd

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-09-15  9:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 10:44 [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc Roger Quadros
2016-08-17 10:44 ` [PATCH 1/1] ARM: keystone: defconfig: Fix USB configuration Roger Quadros
2016-08-17 16:23   ` Santosh Shilimkar
2016-08-25 16:39     ` Santosh Shilimkar
2016-09-12 11:33       ` Roger Quadros
2016-09-15  9:47         ` Arnd Bergmann
2016-08-17 16:24 ` [PATCH 0/1] ARM: Keystone: Fix USB on v4.8-rc Santosh Shilimkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).