* [PATCH][next] staging: r8822be: fix type in guard macro __PHYDMKFREE_H__
@ 2018-03-23 17:36 Colin King
2018-03-23 17:38 ` NACK: " Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-03-23 17:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Ping-Ke Shih, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The #define for __PHYDMKFREE_H__ is missing a character and is not
the same as the guard check. Defined this correctly.
Cleans up clang warning:
warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
by #define of a different macro [-Wheader-guard]
Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/rtlwifi/phydm/phydm_kfree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm_kfree.h b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
index 1ee60059afc1..2c6b0a48e76e 100644
--- a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
+++ b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
@@ -24,7 +24,7 @@
*****************************************************************************/
#ifndef __PHYDMKFREE_H__
-#define __PHYDKFREE_H__
+#define __PHYDKKFREE_H__
#define KFREE_VERSION "1.0"
--
2.15.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* NACK: [PATCH][next] staging: r8822be: fix type in guard macro __PHYDMKFREE_H__
2018-03-23 17:36 [PATCH][next] staging: r8822be: fix type in guard macro __PHYDMKFREE_H__ Colin King
@ 2018-03-23 17:38 ` Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: Colin Ian King @ 2018-03-23 17:38 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger, Ping-Ke Shih, devel
Cc: kernel-janitors, linux-kernel
On 23/03/18 17:36, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The #define for __PHYDMKFREE_H__ is missing a character and is not
> the same as the guard check. Defined this correctly.
>
> Cleans up clang warning:
> warning: '__PHYDMKFREE_H__' is used as a header guard here, followed
> by #define of a different macro [-Wheader-guard]
>
> Fixes: 9ce99b04b5b8 ("staging: r8822be: Add phydm mini driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/rtlwifi/phydm/phydm_kfree.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/phydm/phydm_kfree.h b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> index 1ee60059afc1..2c6b0a48e76e 100644
> --- a/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> +++ b/drivers/staging/rtlwifi/phydm/phydm_kfree.h
> @@ -24,7 +24,7 @@
> *****************************************************************************/
>
> #ifndef __PHYDMKFREE_H__
> -#define __PHYDKFREE_H__
> +#define __PHYDKKFREE_H__
>
> #define KFREE_VERSION "1.0"
>
>
Scrub that, I'll send a V2 of this.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-23 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 17:36 [PATCH][next] staging: r8822be: fix type in guard macro __PHYDMKFREE_H__ Colin King
2018-03-23 17:38 ` NACK: " Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).