* [PATCH] drm/msm/dpu: Add newline to printks
@ 2020-09-28 19:16 Stephen Boyd
2020-09-28 19:21 ` [Freedreno] " abhinavk
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2020-09-28 19:16 UTC (permalink / raw)
To: Rob Clark, Sean Paul
Cc: linux-kernel, linux-arm-msm, dri-devel, freedreno, Abhinav Kumar,
Jeykumar Sankaran
Printk messages need newlines. Add it here.
Cc: Abhinav Kumar <abhinavk@codeaurora.org>
Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index f272a8d0f95b..cbe0461246f8 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -906,7 +906,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
}
mode = &state->adjusted_mode;
- DPU_DEBUG("%s: check", dpu_crtc->name);
+ DPU_DEBUG("%s: check\n", dpu_crtc->name);
/* force a full mode set if active state changed */
if (state->active_changed)
@@ -1012,7 +1012,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc *crtc,
}
pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0;
- DPU_DEBUG("%s: zpos %d", dpu_crtc->name, z_pos);
+ DPU_DEBUG("%s: zpos %d\n", dpu_crtc->name, z_pos);
}
for (i = 0; i < multirect_count; i++) {
--
Sent by a computer, using git, on the internet
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks
2020-09-28 19:16 [PATCH] drm/msm/dpu: Add newline to printks Stephen Boyd
@ 2020-09-28 19:21 ` abhinavk
0 siblings, 0 replies; 2+ messages in thread
From: abhinavk @ 2020-09-28 19:21 UTC (permalink / raw)
To: Stephen Boyd
Cc: Rob Clark, Sean Paul, linux-arm-msm, linux-kernel, dri-devel,
Jeykumar Sankaran, freedreno
On 2020-09-28 12:16, Stephen Boyd wrote:
> Printk messages need newlines. Add it here.
>
> Cc: Abhinav Kumar <abhinavk@codeaurora.org>
> Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index f272a8d0f95b..cbe0461246f8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -906,7 +906,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc
> *crtc,
> }
>
> mode = &state->adjusted_mode;
> - DPU_DEBUG("%s: check", dpu_crtc->name);
> + DPU_DEBUG("%s: check\n", dpu_crtc->name);
>
> /* force a full mode set if active state changed */
> if (state->active_changed)
> @@ -1012,7 +1012,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc
> *crtc,
> }
>
> pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0;
> - DPU_DEBUG("%s: zpos %d", dpu_crtc->name, z_pos);
> + DPU_DEBUG("%s: zpos %d\n", dpu_crtc->name, z_pos);
> }
>
> for (i = 0; i < multirect_count; i++) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-28 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 19:16 [PATCH] drm/msm/dpu: Add newline to printks Stephen Boyd
2020-09-28 19:21 ` [Freedreno] " abhinavk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).