* [PATCH] blk-stat: fix a typo
@ 2016-12-03 1:13 Shaohua Li
2016-12-03 3:16 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Shaohua Li @ 2016-12-03 1:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Kernel-team, axboe
Signed-off-by: Shaohua Li <shli@fb.com>
---
block/blk-stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-stat.c b/block/blk-stat.c
index 688c958..4d01185 100644
--- a/block/blk-stat.c
+++ b/block/blk-stat.c
@@ -12,7 +12,7 @@
static void blk_stat_flush_batch(struct blk_rq_stat *stat)
{
const s32 nr_batch = READ_ONCE(stat->nr_batch);
- const s32 nr_samples = READ_ONCE(stat->nr_batch);
+ const s32 nr_samples = READ_ONCE(stat->nr_samples);
if (!nr_batch)
return;
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-stat: fix a typo
2016-12-03 1:13 [PATCH] blk-stat: fix a typo Shaohua Li
@ 2016-12-03 3:16 ` Jens Axboe
2016-12-03 3:19 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2016-12-03 3:16 UTC (permalink / raw)
To: Shaohua Li, linux-kernel; +Cc: Kernel-team
On 12/02/2016 06:13 PM, Shaohua Li wrote:
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
> block/blk-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-stat.c b/block/blk-stat.c
> index 688c958..4d01185 100644
> --- a/block/blk-stat.c
> +++ b/block/blk-stat.c
> @@ -12,7 +12,7 @@
> static void blk_stat_flush_batch(struct blk_rq_stat *stat)
> {
> const s32 nr_batch = READ_ONCE(stat->nr_batch);
> - const s32 nr_samples = READ_ONCE(stat->nr_batch);
> + const s32 nr_samples = READ_ONCE(stat->nr_samples);
>
> if (!nr_batch)
> return;
>
Gah, that sucks. Thanks, added for 4.10.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blk-stat: fix a typo
2016-12-03 3:16 ` Jens Axboe
@ 2016-12-03 3:19 ` Jens Axboe
0 siblings, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2016-12-03 3:19 UTC (permalink / raw)
To: Shaohua Li, linux-kernel; +Cc: Kernel-team
On 12/02/2016 08:16 PM, Jens Axboe wrote:
> On 12/02/2016 06:13 PM, Shaohua Li wrote:
>> Signed-off-by: Shaohua Li <shli@fb.com>
>> ---
>> block/blk-stat.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-stat.c b/block/blk-stat.c
>> index 688c958..4d01185 100644
>> --- a/block/blk-stat.c
>> +++ b/block/blk-stat.c
>> @@ -12,7 +12,7 @@
>> static void blk_stat_flush_batch(struct blk_rq_stat *stat)
>> {
>> const s32 nr_batch = READ_ONCE(stat->nr_batch);
>> - const s32 nr_samples = READ_ONCE(stat->nr_batch);
>> + const s32 nr_samples = READ_ONCE(stat->nr_samples);
>>
>> if (!nr_batch)
>> return;
>>
>
> Gah, that sucks. Thanks, added for 4.10.
BTW, this was added right before inclusion, all the previously posted
versions were not broken in this way. So thanks for spotting this!
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-03 4:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-03 1:13 [PATCH] blk-stat: fix a typo Shaohua Li
2016-12-03 3:16 ` Jens Axboe
2016-12-03 3:19 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).