* [PATCH] usb: typec: mux: intel: Add dependency on USB_COMMON
@ 2023-07-31 13:12 Heikki Krogerus
2023-07-31 23:09 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Heikki Krogerus @ 2023-07-31 13:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Randy Dunlap, Rajat Khandelwal
This fixes an undefined reference to `usb_debug_root' issue
when USB_COMMON is not enabled.
Fixes: 0a453dc9f260 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/lkml/c3bb8781-676d-2448-cfbb-62e29f1f570b@infradead.org/
Cc: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/usb/typec/mux/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
index 784b9d8107e9b..65da61150ba78 100644
--- a/drivers/usb/typec/mux/Kconfig
+++ b/drivers/usb/typec/mux/Kconfig
@@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC
tristate "Intel PMC mux control"
depends on ACPI
depends on INTEL_SCU_IPC
+ select USB_COMMON
select USB_ROLE_SWITCH
help
Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: mux: intel: Add dependency on USB_COMMON
2023-07-31 13:12 [PATCH] usb: typec: mux: intel: Add dependency on USB_COMMON Heikki Krogerus
@ 2023-07-31 23:09 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2023-07-31 23:09 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, Rajat Khandelwal
On 7/31/23 06:12, Heikki Krogerus wrote:
> This fixes an undefined reference to `usb_debug_root' issue
> when USB_COMMON is not enabled.
>
> Fixes: 0a453dc9f260 ("usb: typec: intel_pmc_mux: Expose IOM port status to debugfs")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Closes: https://lore.kernel.org/lkml/c3bb8781-676d-2448-cfbb-62e29f1f570b@infradead.org/
> Cc: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/usb/typec/mux/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 784b9d8107e9b..65da61150ba78 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -29,6 +29,7 @@ config TYPEC_MUX_INTEL_PMC
> tristate "Intel PMC mux control"
> depends on ACPI
> depends on INTEL_SCU_IPC
> + select USB_COMMON
> select USB_ROLE_SWITCH
> help
> Driver for USB muxes controlled by Intel PMC FW. Intel PMC FW can
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-31 23:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-31 13:12 [PATCH] usb: typec: mux: intel: Add dependency on USB_COMMON Heikki Krogerus
2023-07-31 23:09 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).