From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: wei.fang@nxp.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch,
f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: tja11xx: add nxp,refclk_in property
Date: Fri, 19 Aug 2022 12:14:01 +0300 [thread overview]
Message-ID: <f0f6e8af-4006-e0e8-544b-f2f892d79a1f@linaro.org> (raw)
In-Reply-To: <20220819074729.1496088-2-wei.fang@nxp.com>
On 19/08/2022 10:47, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> TJA110x REF_CLK can be configured as interface reference clock
> intput or output when the RMII mode enabled. This patch add the
> property to make the REF_CLK can be configurable.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> .../devicetree/bindings/net/nxp,tja11xx.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> index d51da24f3505..c51ee52033e8 100644
> --- a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
> @@ -31,6 +31,22 @@ patternProperties:
> description:
> The ID number for the child PHY. Should be +1 of parent PHY.
>
> + nxp,rmii_refclk_in:
No underscores in properties.
> + type: boolean
> + description: |
> + The REF_CLK is provided for both transmitted and receivced data
typo: received
> + in RMII mode. This clock signal is provided by the PHY and is
> + typically derived from an external 25MHz crystal. Alternatively,
> + a 50MHz clock signal generated by an external oscillator can be
> + connected to pin REF_CLK. A third option is to connect a 25MHz
> + clock to pin CLK_IN_OUT. So, the REF_CLK should be configured
> + as input or output according to the actual circuit connection.
> + If present, indicates that the REF_CLK will be configured as
> + interface reference clock input when RMII mode enabled.
> + If not present, the REF_CLK will be configured as interface
> + reference clock output when RMII mode enabled.
> + Only supported on TJA1100 and TJA1101.
Then disallow it on other variants.
Shouldn't this be just "clocks" property?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-19 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 7:47 [PATCH net-next 0/2] add interface mode select and RMII wei.fang
2022-08-19 7:47 ` [PATCH net-next 1/2] dt-bindings: net: tja11xx: add nxp,refclk_in property wei.fang
2022-08-19 9:14 ` Krzysztof Kozlowski [this message]
2022-08-19 9:37 ` Wei Fang
2022-08-19 11:37 ` Krzysztof Kozlowski
2022-08-19 12:44 ` Andrew Lunn
2022-08-19 12:52 ` Krzysztof Kozlowski
2022-08-19 7:47 ` [PATCH net-next 2/2] net: phy: tja11xx: add interface mode and RMII REF_CLK support wei.fang
2022-08-19 12:50 ` Andrew Lunn
2022-08-22 1:16 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f6e8af-4006-e0e8-544b-f2f892d79a1f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).