* [PATCH] HID: wacom: Simplify comments
@ 2022-07-31 19:39 Christophe JAILLET
2022-08-02 15:38 ` Jason Gerecke
2022-08-02 18:41 ` Ping Cheng
0 siblings, 2 replies; 4+ messages in thread
From: Christophe JAILLET @ 2022-07-31 19:39 UTC (permalink / raw)
To: Ping Cheng, Jason Gerecke, Jiri Kosina, Benjamin Tissoires
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-input
Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
boilerplate/reference with SPDX - rule 152").
An empty comment block can be removed.
While at it remove, also remove what is supposed to be the path/filename of
the file.
This is really low value... and wrong since commit 471d17148c8b
("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/hid/wacom_sys.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 194a2e327591..21612fdae9c3 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1,13 +1,8 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
- * drivers/input/tablet/wacom_sys.c
- *
* USB Wacom tablet support - system specific code
*/
-/*
- */
-
#include "wacom_wac.h"
#include "wacom.h"
#include <linux/input/mt.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: wacom: Simplify comments
2022-07-31 19:39 [PATCH] HID: wacom: Simplify comments Christophe JAILLET
@ 2022-08-02 15:38 ` Jason Gerecke
2022-08-02 18:41 ` Ping Cheng
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gerecke @ 2022-08-02 15:38 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Ping Cheng, Jason Gerecke, Jiri Kosina, Benjamin Tissoires, LKML,
kernel-janitors, Linux Input
On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.
>
> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/hid/wacom_sys.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * drivers/input/tablet/wacom_sys.c
> - *
> * USB Wacom tablet support - system specific code
> */
>
> -/*
> - */
> -
> #include "wacom_wac.h"
> #include "wacom.h"
> #include <linux/input/mt.h>
> --
> 2.34.1
>
LGTM.
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: wacom: Simplify comments
2022-07-31 19:39 [PATCH] HID: wacom: Simplify comments Christophe JAILLET
2022-08-02 15:38 ` Jason Gerecke
@ 2022-08-02 18:41 ` Ping Cheng
2022-08-02 18:47 ` Christophe JAILLET
1 sibling, 1 reply; 4+ messages in thread
From: Ping Cheng @ 2022-08-02 18:41 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Ping Cheng, Jason Gerecke, Jiri Kosina, Benjamin Tissoires,
linux-kernel, kernel-janitors, linux-input
Hi Christophe,
Thank you for cleaning up the driver code.
On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
> boilerplate/reference with SPDX - rule 152").
> An empty comment block can be removed.
While you are here, can you update your patch to include the removal
of the empty comment blocks and paths in the other three files:
wacom.h, wacom_wac.h, and wacom_wac.c?
Thanks,
Ping
> While at it remove, also remove what is supposed to be the path/filename of
> the file.
> This is really low value... and wrong since commit 471d17148c8b
> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/hid/wacom_sys.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 194a2e327591..21612fdae9c3 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1,13 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> - * drivers/input/tablet/wacom_sys.c
> - *
> * USB Wacom tablet support - system specific code
> */
>
> -/*
> - */
> -
> #include "wacom_wac.h"
> #include "wacom.h"
> #include <linux/input/mt.h>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: wacom: Simplify comments
2022-08-02 18:41 ` Ping Cheng
@ 2022-08-02 18:47 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2022-08-02 18:47 UTC (permalink / raw)
To: Ping Cheng
Cc: Ping Cheng, Jason Gerecke, Jiri Kosina, Benjamin Tissoires,
linux-kernel, kernel-janitors, linux-input
Le 02/08/2022 à 20:41, Ping Cheng a écrit :
> Hi Christophe,
>
> Thank you for cleaning up the driver code.
>
> On Sun, Jul 31, 2022 at 12:51 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>>
>> Remove a left-over from commit 2874c5fd2842 ("treewide: Replace GPLv2
>> boilerplate/reference with SPDX - rule 152").
>> An empty comment block can be removed.
>
> While you are here, can you update your patch to include the removal
> of the empty comment blocks and paths in the other three files:
> wacom.h, wacom_wac.h, and wacom_wac.c?
I'll send a v2.
Thanks for pointing it out.
CJ
>
> Thanks,
> Ping
>
>> While at it remove, also remove what is supposed to be the path/filename of
>> the file.
>> This is really low value... and wrong since commit 471d17148c8b
>> ("Input: wacom - move the USB (now hid) Wacom driver in drivers/hid")
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> drivers/hid/wacom_sys.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
>> index 194a2e327591..21612fdae9c3 100644
>> --- a/drivers/hid/wacom_sys.c
>> +++ b/drivers/hid/wacom_sys.c
>> @@ -1,13 +1,8 @@
>> // SPDX-License-Identifier: GPL-2.0-or-later
>> /*
>> - * drivers/input/tablet/wacom_sys.c
>> - *
>> * USB Wacom tablet support - system specific code
>> */
>>
>> -/*
>> - */
>> -
>> #include "wacom_wac.h"
>> #include "wacom.h"
>> #include <linux/input/mt.h>
>> --
>> 2.34.1
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-02 18:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-31 19:39 [PATCH] HID: wacom: Simplify comments Christophe JAILLET
2022-08-02 15:38 ` Jason Gerecke
2022-08-02 18:41 ` Ping Cheng
2022-08-02 18:47 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).